[PIPE2D-124] include the new redFiberTraces.fits file in the DRP Created: 15/Nov/16  Updated: 24/Jan/17  Resolved: 24/Jan/17

Status: Won't Fix
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Major
Reporter: aritter Assignee: aritter
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
is blocked by PIPE2D-119 Update test data in drp_stella_data Done
Relates
relates to PIPE2D-149 quick-start guide: replace reduceArcR... Won't Fix
Story Points: 1
Sprint: 2014-16
Reviewers: cloomis

 Description   

Please use the new redFiberTrace.fits file, which includes the (fiber#,y)->wavelength map, in reduceArcTask.py and the tests in drp_stella. This includes small changes in FiberTraces.h/cc assignITrace and findITrace as there is no yCenter column any more in the new file



 Comments   
Comment by cloomis [ 16/Nov/16 ]

This confuses me: isn't the point of DAMD-11 to avoid publishing the one-time hack redFiberTraces.fits? If we get any formal wavelength solution persistence then we can forget that we ever needed this file.

Comment by aritter [ 16/Nov/16 ]

Until DAMD-11 is implemented we still want the redFiberTraces.fits to make the tests pass again. As the format has changed compared to the old version of the file some code changes are required for which a ticket is needed.

Comment by aritter [ 18/Nov/16 ]

Ready for review once PIPE2D-119 is merged into master. Tests in Spectra.py pass again.

Comment by aritter [ 18/Dec/16 ]

Changes are in drp_stella and obs_pfs tickets/PIPE2D-124

Comment by swinbank [ 10/Jan/17 ]

Per our meeting of 2017-01-09, aritter will check if this ticket is actually still necessary. Since we expect that this work to be rendered obsolete by DAMD-11, this will be marked as "won't fix" unless it's actively breaking tests in the short term.

Comment by aritter [ 18/Jan/17 ]

It turns out that the old file RedFiberPixels.fits.gz is sufficient since the geometry bug was fixed in Craig's simulations. However I recommend adopting the remaining changes in drp_stella tickets/PIPE2D-124 as they are improvements to the code. Part of the changes undo changes we made when the new test data containing the geometry bug in the simulations were introduced. Another part removes un-used imports and variables. We could rename the issue and submit it to review, which should be a quick one...

Comment by swinbank [ 19/Jan/17 ]

Given the above, we agreed at our meeting of 2017-01-18 that this ticket should be closed as "won't fix", and we need three new tickets to take care of the work which currently exists on the PIPE2D-124 ticket branch (which is worth saving).

aritter will file those tickets then mark this as "won't fix".

Comment by aritter [ 24/Jan/17 ]

Removing the `yCenters` parameter from `assignITrace` and `findITrace` is done as part of PIPE2D-138.
Removing unused import from testDrp.py will be done in PIPE2D-69.
Filed ticket PIPE2D-149 to replace `reduceArcRefSpec.py` with `reduceArc.py` in the quick-start guide.

Generated at Sat Feb 10 15:48:41 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.