[PIPE2D-124] include the new redFiberTraces.fits file in the DRP Created: 15/Nov/16 Updated: 24/Jan/17 Resolved: 24/Jan/17 |
|
| Status: | Won't Fix |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Major |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Sprint: | 2014-16 | ||||||||||||||||
| Reviewers: | cloomis | ||||||||||||||||
| Description |
|
Please use the new redFiberTrace.fits file, which includes the (fiber#,y)->wavelength map, in reduceArcTask.py and the tests in drp_stella. This includes small changes in FiberTraces.h/cc assignITrace and findITrace as there is no yCenter column any more in the new file |
| Comments |
| Comment by cloomis [ 16/Nov/16 ] |
|
This confuses me: isn't the point of |
| Comment by aritter [ 16/Nov/16 ] |
|
Until |
| Comment by aritter [ 18/Nov/16 ] |
|
Ready for review once |
| Comment by aritter [ 18/Dec/16 ] |
|
Changes are in drp_stella and obs_pfs tickets/ |
| Comment by swinbank [ 10/Jan/17 ] |
|
Per our meeting of 2017-01-09, aritter will check if this ticket is actually still necessary. Since we expect that this work to be rendered obsolete by |
| Comment by aritter [ 18/Jan/17 ] |
|
It turns out that the old file RedFiberPixels.fits.gz is sufficient since the geometry bug was fixed in Craig's simulations. However I recommend adopting the remaining changes in drp_stella tickets/ |
| Comment by swinbank [ 19/Jan/17 ] |
|
Given the above, we agreed at our meeting of 2017-01-18 that this ticket should be closed as "won't fix", and we need three new tickets to take care of the work which currently exists on the aritter will file those tickets then mark this as "won't fix". |
| Comment by aritter [ 24/Jan/17 ] |
|
Removing the `yCenters` parameter from `assignITrace` and `findITrace` is done as part of |