[PIPE2D-1238] fitPfsFluxReference should not brute-force the model fitting Created: 16/Jun/23 Updated: 29/Jun/23 Resolved: 29/Jun/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | sogo.mineo | Assignee: | sogo.mineo |
| Resolution: | Done | Votes: | 0 |
| Labels: | flux-calibration | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Reviewers: | price | ||||||||||||
| Description |
|
The current fitPfsFluxReference naively compares observed spectra with ~60,000 model spectra Now that the model interpolator has become decently small in memory consumption It is essential to guess a good initial guess if we are to use an optimizer, On optimizersI have compared "Powell" method with "Nelder-Mead" method (both do not require differentiability) Comparison between "Powell" method and the brute-force methodThe success rate of "Powell" method depends on the order of parameters Percentages below are (RMS(input - output)) / (stddev(input)) obtained from a test with 100 fibers.
master powell
Teff 12.46% 10.96%
log(g) 27.00% 23.62%
metal 43.78% 41.85%
alpha 91.30% 88.75%
The master branch takes 25647 seconds to fit 100 fibers, but with Powell's method, the fitting takes only 7420 seconds Powell's method outperforms the master branch (brute-force method) not only in speed but in quality. |
| Comments |
| Comment by sogo.mineo [ 20/Jun/23 ] |
|
Could you review this PR? |
| Comment by sogo.mineo [ 29/Jun/23 ] |
|
Merged. Thanks for reviewing. |