[PIPE2D-1168] fitPfsReferenceFlux breaks Tiger Created: 22/Feb/23 Updated: 16/Jun/23 Resolved: 01/Mar/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Description |
|
Running fitPfsReferenceFlux on our Tiger head node trashes the machine. I am reducing the new weekly: fitPfsReferenceFlux.py /scratch/pprice/sim2d-151/test --calib=/scratch/pprice/sim2d-151/test/CALIB --rerun=weekly/pipeline/brn/pipeline --doraise -j10 --no-versions --clobber-config --id 'visit=47^48^49^53^54^57' 'arm=b^r^n' I suspect that the fluxmodeldata is being accessed within a tight loop, which causes a huge load on the disk. |
| Comments |
| Comment by price [ 23/Feb/23 ] |
|
Moving the fluxmodeldata to a faster disk has alleviated the problem on tiger. I took the opportunity to look at the fitPfsFluxReference code and made some observations that might help improve it moving forward:
Stepping back from the details of the current implementation, I think that this would go much faster with a modified algorithm: |
| Comment by sogo.mineo [ 27/Feb/23 ] |
|
Thanks for the suggestions. I will think about them a few days later, once my urgent task is done. |
| Comment by sogo.mineo [ 06/Mar/23 ] |
|
> All the spectra are going into the interpolation, even though many are strongly down-weighted. I suggest using the neighbours parameter of the RBFInterpolator. I have not tried it, but I don't think any parameter will help reduce memory usage. RBFInterpolator needs all the input spectra to be on memory by nature. Yamashita-san said that we might be able to construct RBFInterpolator every time it is required, from only a few spectra around the initial guess (Teff0, logg0, m0, alpha0) – if we can find the initial guess accurately. |
| Comment by Takuji Yamashita [ 06/Mar/23 ] |
|
Thank you for your suggestions about the algorithm! Mineo-san has implemented the cut-off threshold to narrow down the models after broad-band fitting in It is worth a try your idea using line indices and a minimizer. Stabilizing and optimizing the current flux calibration is a priority, but we may want to start a study of your algorithm.
|