[PIPE2D-1163] Allow adding FITS cards to pfsConfig PHDU Created: 16/Feb/23 Updated: 23/Feb/23 Resolved: 23/Feb/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | datamodel |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
Per From Slack discussions, I believe we agreed to add a header=[Dict[name, (value, comment)]] argument to the pfsConfig constructor. When the .write() method is called, those cards will be written to the PHDU. Side note: for now we will add a PROP-ID proposal card. Once the requirements are understood, there will likely be a new proposal column in the config table, giving one proposal per fiber. |
| Comments |
| Comment by cloomis [ 17/Feb/23 ] |
|
One obnoxiousness is that we need to add a DATE-OBS card to the pfsConfig PHDU. Actually making that match the PFS[AB] files would be hard. Also not really useful: the visit is the thing which groups all the components together. So I think `DATE-OBS` should be added by PfsConfig._writeImp(). price? |
| Comment by price [ 17/Feb/23 ] |
|
Is there a reason that can't be in the header? |
| Comment by cloomis [ 18/Feb/23 ] |
|
No. I probably just wanted to make someone else lie about the date. Nevermind. |
| Comment by cloomis [ 18/Feb/23 ] |
|
We are required to add CHECKSUM/DATASUM. I think that just means adding checksum=True to the fits.writeto() call. Objections? Do we need the FiberType and TargetStatus definitions used in the fiberStatus table to be in the PHDU? Can those be added to the header for the DESIGN HDU after writing the PHDU? We have been given a provisional pass on putting HIERARCH in the PHDUs, but can we remove them entirely without breaking code? Looks to me that they are read from the DESIGN HDU, so do not need to be written to the PHDU as well. |
| Comment by price [ 18/Feb/23 ] |
|
I'm fine with adding CHECKSUM (we should do that everywhere) and moving the FiberStatus and TargetType to the table HDU. |