[PIPE2D-1159] Please always provide a detectorMap_used file Created: 12/Feb/23  Updated: 14/Feb/23  Resolved: 14/Feb/23

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: arnaud.lefur

 Description   

Please always write detectorMap_used even if it's identical to detectorMap; this allows users to get into the habit of always using the best available map

 Comments   
Comment by price [ 12/Feb/23 ]

Could you please give an example of when a detectorMap_used is not available after running reduceExposure?

Comment by rhl [ 12/Feb/23 ]

I don't see any in /work/rhl/rerun/rhl/tickets/PIPE2D-1136 on the Hilo server.

I think that the magic config is photometerLines.doApertureCorrection=False although that seems unlikely.

Comment by price [ 12/Feb/23 ]

Ah, it's only written if doAdjustDetectorMap is True: https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/reduceExposure.py#L538
That's easily fixed. (But why would you run without that?)

Comment by rhl [ 12/Feb/23 ]

Because, at times, doAdjustDetectorMap has made matters worse. I'm sure that'll never happen again

Comment by arnaud.lefur [ 13/Feb/23 ]

I usually turn it off in hilo for the "on the fly" reduction, because it's much faster without.
Also, we were taking mostly windowed exposure and wasn't sure if the fitting code is able to handle that.

Comment by price [ 14/Feb/23 ]

arnaud.lefur, would you like to take this for a test drive before I merge?

Comment by arnaud.lefur [ 14/Feb/23 ]

Yes, just did a quick test and it worked .

Comment by price [ 14/Feb/23 ]

Merged to master.

Generated at Sat Feb 10 16:03:34 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.