[PIPE2D-1149] Support Gen3 in flux calibration Created: 18/Jan/23 Updated: 20/Apr/23 Resolved: 20/Apr/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | Takuji Yamashita | Assignee: | sogo.mineo |
| Resolution: | Done | Votes: | 0 |
| Labels: | flux-calibration | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | flux calibration |
| Reviewers: | price |
| Description |
|
Make changes to the flux calibration part to support Gen3. |
| Comments |
| Comment by sogo.mineo [ 27/Jan/23 ] |
|
I have made FitPfsFluxReferenceTask and FitFluxCalTask compatible with gen3 butler. To run them, pass pipetask a YAML file like the following one:
description: Full 2D-DRP science pipeline containing {{FitPfsFluxReferenceTask}}
imports:
- $DRP_STELLA_DIR/pipelines/reduceExposure.yaml
tasks:
fitPfsFluxReference:
class: pfs.drp.stella.fitPfsFluxReference.FitPfsFluxReferenceTask
config:
minBroadbandFluxes: 1
fitFluxCal:
class: pfs.drp.stella.fitFluxCal.FitFluxCalTask
coaddSpectra:
class: pfs.drp.stella.coaddSpectra.CoaddSpectraTask
I have confirmed that this pipeline can process the data set for the integration test. |
| Comment by sogo.mineo [ 27/Jan/23 ] |
|
Could you review this PR? |
| Comment by price [ 31/Jan/23 ] |
|
Can we put that YAML in drp_stella/pipelines? |
| Comment by sogo.mineo [ 31/Jan/23 ] |
|
What name will be appropriate for this file? I temporarily named it science2.yaml. |
| Comment by price [ 31/Jan/23 ] |
|
That sounds fine for now. We'll rename it later when we properly adopt Gen3. |
| Comment by sogo.mineo [ 20/Apr/23 ] |
|
I have forgot to close this issue. Thanks for reviewing. |