[PIPE2D-1143] sky subtraction is bad for a certain fraction of fibers in the faint galaxy frames taken during Nov run Created: 13/Jan/23 Updated: 17/Feb/23 Resolved: 17/Feb/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | Kiyoto Yabe | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | collab-datarelease | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||
| Sprint: | 2DDRP-2023 A | ||||||||||||||||||||||||
| Reviewers: | hassan | ||||||||||||||||||||||||
| Description |
|
Reducing the data for faint galaxies (visit=83244..83249) taken during the Nov run, I just noticed that the sky subtraction for some fibers is (still) significantly bad. Commands I ran are in this reduction_run08_galaxies_example.sh
|
| Comments |
| Comment by price [ 14/Jan/23 ] |
|
Could you please tell me how the sky fiber positions were selected? |
| Comment by Kiyoto Yabe [ 14/Jan/23 ] |
|
Sky fibers used for the subtraction? I didn't specify them so config.selectSky.fiberFilter='ALL'. |
| Comment by rhl [ 14/Jan/23 ] |
|
I thought that this was a "proper" extra-Galactic field from HSC, so shouldn't we have SKY objects? Will we have SKY objects in the next engineering runs? I don't think that this can explain the problem, though, as we are over subtracting the OH. |
| Comment by Kiyoto Yabe [ 14/Jan/23 ] |
|
Murata-san's sky object DB was used and we have 500 SKY fibers (in entire focal plane not SM1&3) in this field. |
| Comment by rhl [ 15/Jan/23 ] |
|
Ah, OK. So they were specified in the pfsDesign, which is all that matters. You shouldn't ever need to config.selectSky.fiberFilter except for interactive fiddling (a better solution is to write a pfsConfig to the rerun). |
| Comment by Kiyoto Yabe [ 17/Jan/23 ] |
|
FWIW, attached is the location of fibers with large residual (using an isolated sky line) and sky fibers on PFI plane. It looks that there is no strong (anti-) correlation?
|
| Comment by price [ 21/Jan/23 ] |
|
This is due to fibers being in the penumbra of nearby black spots. Based on a bunch of sky lines from two exposures (83149 and 83244), the throughput appears to be linear with distance from the black spot (slope of 1.232/mm) up to a distance of 1.108 mm.
|
| Comment by price [ 04/Feb/23 ] |
|
This includes the changes of |
| Comment by hassan [ 11/Feb/23 ] |
|
Changes approved. Could not see any obvious issues with the proposed changes, including the new notes mechanism. Perhaps a slope to model the penumbra may be too simplistic for the future, but it works now and is a good start. |
| Comment by price [ 12/Feb/23 ] |
|
Need to check: it looks like I might be making the correction twice (once in extractSpectra, and once in reduceExposure). |
| Comment by price [ 14/Feb/23 ] |
|
I double-checked, and I am not making the correction twice. The second correction is in pfs.drp.stella.pipelines.extractSpectra (part of the Gen3 pipeline that replaces reduceExposure), not pfs.drp.stella.extractSpectra (the building block). |
| Comment by price [ 17/Feb/23 ] |
|
Merged to master. |