[PIPE2D-1137] add flags in LineList Created: 05/Jan/23  Updated: 06/May/23  Resolved: 06/May/23

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: fmadec Assignee: hassan
Resolution: Done Votes: 0
Labels: SPS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

I would like to have 2 flags in the LineList to identify the lines used by LAM to make detector focus adjustment and one for the image quality measurement.

if it is ok, how it works? how do we proceed?



 Comments   
Comment by price [ 05/Jan/23 ]

How do you use DRP2D outputs for focus adjustment and image quality measurement?

Comment by hassan [ 05/Jan/23 ]

I've added to the ticket branch the following flags:

LAM_FOCUS = 0x800, "Line is used by LAM for detector focus purposes"
LAM_IMAGEQUALITY = 0x1000, "Line is used by LAM for image quality measurement"

Fabrice: To use those, edit the appropriate linelist file in the obs_pfs package. For the line that needs to be updated, logically bitwise-OR one of the above hex values with the existing value in the status field for that line.

Comment by price [ 05/Jan/23 ]

Bitwise-OR, not logical-OR.

Comment by hassan [ 05/Jan/23 ]

Bitwise-OR of course. Comment updated.

Comment by fmadec [ 05/Jan/23 ]

thanks!

one question, can I combine them ? I mean mark one line with both flags?

Comment by hassan [ 05/Jan/23 ]

Yes. Just bitwise-OR all flags to the status value.

Comment by fmadec [ 05/Jan/23 ]

back to your question Paul: How do you use DRP2D outputs for focus adjustment and image quality measurement?

right now I simply used detrend images and I have a separate list of peaks that I used (and tweak on purpose). But the lines are identified and I like to store them here. 
during the alignment it is a bit tricky, focus is not necessary good and lines position moves.

for the image quality I could use reduceArc or smthg else for DRPED to have position of lines, but I already have all code running without... will see

 

Comment by price [ 06/May/23 ]

Integration test passed. Merged to master.

Generated at Sat Feb 10 16:03:15 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.