[PIPE2D-1128] Fix weekly breakage 2022-12-11 Created: 13/Dec/22 Updated: 17/Dec/22 Resolved: 17/Dec/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | hassan |
| Description |
|
The weekly of 2022-12-11 failed while looking at the wavelength residuals: ====================================================================== FAIL: testResiduals (__main__.ArcTestCase_brn_39) (visit=39, arm='r', fiberId=2) Test that wavelength fit residuals are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File "/scratch/pprice/jenkins/weekly/2022-12-11/build/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pfs_pipe2d/w.2022.50/python/pfs/pipe2d/weekly/test_weekly.py", line 138, in testResiduals self.assertFloatsAlmostEqual(median, 0.0, atol=atol) File "/scratch/pprice/jenkins/weekly/2022-12-11/build/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/utils/g62e1f4f43a+9633a190c8/python/lsst/utils/tests.py", line 715, in assertFloatsAlmostEqual testCase.assertFalse(failed, msg="\n".join(errMsg)) AssertionError: True is not false : 0.04064752062453181 != 0.0; diff=0.04064752062453181/0.04064752062453181=1.0 with rtol=2.220446049250313e-16, atol=0.02 This is likely related to |
| Comments |
| Comment by price [ 14/Dec/22 ] |
|
This was due to including Trace pseudo-lines in the the wavelength residual measurements. They don't have real wavelengths, so it doesn't make sense to include them. The Trace lines weren't being output previously, so this is a sign of improvements! |
| Comment by hassan [ 17/Dec/22 ] |
|
Suggested changes in pull request are fine, thanks. |
| Comment by price [ 17/Dec/22 ] |
|
Merged. |