galaxy.png
[PIPE2D-1120] Header fixes not being applied Created: 29/Nov/22 Updated: 29/Nov/22 Resolved: 29/Nov/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
galaxy.png
|
| Reviewers: | hassan |
| Description |
|
Discovered that the header fixes are not being applied in the pipeline: 81862b3 is being interpreted as having no lamps on, despite the header fix database (where it is fixed to show the quartz on) being rebuilt. |
| Comments |
| Comment by hassan [ 29/Nov/22 ] |
|
Changes in pull request https://github.com/Subaru-PFS/obs_pfs/pull/137 look fine. Not sure if new galaxy linelist can be ingested wholly, but happy to be proven wrong. Please see comments in that PR for details. |
| Comment by price [ 29/Nov/22 ] |
|
The galaxy linelist works: I used it to produce the attached plot. |
| Comment by price [ 29/Nov/22 ] |
|
Merged. |