[PIPE2D-112] Remove unnecessary interfaces from stellaLib.i Created: 02/Nov/16 Updated: 23/Jun/17 Resolved: 23/Jun/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Major |
| Reporter: | rhl | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | 2014-17 | ||||||||
| Reviewers: | swinbank | ||||||||
| Description |
|
Not only are there many commented out lines in stellaLib.i, but there seem to be many unused %template commands. Please remove all unused interfaces. I cleaned out some of these as part of the ndarray fixes ( |
| Comments |
| Comment by swinbank [ 08/Jun/17 ] |
|
What's the process you used to identify "unnecessary interfaces"? Obviously, there's a lot removed on this ticket, but are we sure that we removed everything the ticket asked for? (I guess removing everything then adding them in one at a time until all the tests pass might be a good way to go about things — is that what you did?) I do note that there are still a couple of commented lines in the file. Any reason why we don't just kill those at the same time? |
| Comment by rhl [ 23/Jun/17 ] |
|
Please look at comments and respond, but basically good to merge |
| Comment by aritter [ 23/Jun/17 ] |
|
merged into master |