[PIPE2D-1116] Support more than one spectrograph in raster.py Created: 16/Nov/22 Updated: 22/Apr/23 Resolved: 22/Apr/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Sprint: | PreEng11Apr1 |
| Description |
|
The raster.py code that we used in September assumed that we only have one SM on the mountain. Please relax this assumption |
| Comments |
| Comment by rhl [ 16/Nov/22 ] |
|
The support code is pushed to git. The notebook needs to say something like:
ds = []
for spectrograph in [1, 3]:
dataId.update(visit=v, arm='r', spectrograph=spectrograph)
try:
d = raster.makeDither(drpButler, dataId, fiberTraces=fiberTraces, lmin=lmin, lmax=lmax, camera=camera,
useButler=False, visit0=visit0, usePfsArm=True)
except Exception as e:
print(e)
continue
ds.append(d)
if len(ds) > 1:
d = raster.concatenateDithers(drpButler, ds)
|
| Comment by rhl [ 11/Jan/23 ] |
|
cloomis My part is long done. Please confirm that you have these changes in your code and let's get this closed out. |
| Comment by yuki.moritani [ 24/Feb/23 ] |
|
Since the recent observations were canceled, I'm putting this to backlog for now. (the rest is for Craig to confirm the modifications, and upload the notebook to dev_observation repo.) |
| Comment by rhl [ 22/Apr/23 ] |
|
Merged to master after RHL+CPL review at MKO |