[PIPE2D-1106] PfsSingle should not be created for fibers with TargetType = ENGINEERING Created: 02/Nov/22 Updated: 08/Feb/23 Resolved: 07/Nov/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | sogo.mineo | Assignee: | sogo.mineo |
| Resolution: | Done | Votes: | 0 |
| Labels: | flux-calibration | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2023 A |
| Reviewers: | price |
| Description |
|
Fibers of these target types have (ra, dec) = (nan, nan) in PfsConfig. This is appropriate because these fibers do not point to the sky. But the coordinates being NaN cause an exception during the process of making PfsSingle, for NaN is not allowed in FITS headers. |
| Comments |
| Comment by sogo.mineo [ 02/Nov/22 ] |
|
Could you review this PR? Yamashita-san has confirmed that he can successfully process his data using this branch. |
| Comment by price [ 03/Nov/22 ] |
|
As rhl pointed out on Slack, UNASSIGNED fibers should still have an ra,dec, and should therefore be included. But ENGINEERING fibers are not directed at the sky, and hence are rightly excluded. |
| Comment by sogo.mineo [ 04/Nov/22 ] |
|
I force-pushed a new change. I would like price to review it again. |
| Comment by price [ 04/Nov/22 ] |
|
Very nice, thanks! |
| Comment by sogo.mineo [ 07/Nov/22 ] |
|
Merged. Thank you for the review. |