[PIPE2D-1103] The n-band std_raw sets the variance. Move this code to the ISR Created: 30/Oct/22 Updated: 13/May/23 Resolved: 13/May/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
For reasons which I no longer remember, the n-band std_raw code which handles simple CDS and ref-pixel processing of n-band data also sets the variance. This is something that is generally done by the ISR, and unless there is a good reason for the current design, we should change it to follow the usual pattern. |
| Comments |
| Comment by price [ 01/Nov/22 ] |
|
I agree this is how we should handle the variance. |
| Comment by hassan [ 01/Nov/22 ] |
|
Changes already merged to master and Paul Price agrees with the approach. |
| Comment by rhl [ 01/Nov/22 ] |
|
I'm confused. That pull request seems to be for tickets/ |
| Comment by hassan [ 01/Nov/22 ] |
|
My mistake. I incorrectly assumed that the merged PR was related to this ticket, so I should not have closed it. |
| Comment by rhl [ 13/May/23 ] |
|
Done as part of |