[PIPE2D-1102] Import DM-35718 solution for Gen2 datasetExists of bypass data Created: 28/Oct/22 Updated: 01/Nov/22 Resolved: 01/Nov/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Reviewers: | hassan | ||||||||||||||||
| Description |
|
DM-35718 ("bypass functions do not play well with datasetExists (in gen2)") fixes a Gen2 butler bug. This fix is essential for our processing of NIR PFSB files. Since the Gen2 middleware has been deprecated (and in many instances, completely removed) by LSST, this fix will not be released by them, and so we need to get it ourselves. This might be done either by installing the daf_persistence branch with the fix or by monkey-patching the butler. The former solution might cause problems with the eups dependencies, so we'll try the latter solution. |
| Comments |
| Comment by price [ 28/Oct/22 ] |
|
This is working and ready for review. Command-line pipeline operations (detrend.py and reduceExposure.py) should work, but notebook operations may need to import lsst.obs.pfs before doing anything else in order to trigger the monkey-patch. |
| Comment by hassan [ 30/Oct/22 ] |
|
Changes look fine, thanks. |
| Comment by price [ 01/Nov/22 ] |
|
Merged. |