[PIPE2D-1097] Include read noise in estimate of variance for H4RG detectors Created: 19/Oct/22  Updated: 08/Feb/23  Resolved: 30/Oct/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: NIR
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2DDRP-2023 A
Reviewers: price

 Description   

Please include the readNoise in the variance estimates for H4RGs (n-band)



 Comments   
Comment by rhl [ 19/Oct/22 ]

https://github.com/Subaru-PFS/obs_pfs/pull/133

Comment by price [ 20/Oct/22 ]

Integration test is failing with errors:

 File "/scratch/pprice/jenkins/integrationTest/454/obs_pfs/python/lsst/obs/pfs/pfsMapper.py", line 361, in std_raw
   raise RuntimeError(f"Rewrite me now we have {len(exp.getDetector())} channels")
RuntimeError: Rewrite me now we have 8 channels

See /scratch/pprice/jenkins/integrationTest/454.

Comment by rhl [ 20/Oct/22 ]

Did something not get rebased? camera.yaml only has one amplifier these days

Comment by price [ 20/Oct/22 ]

I think b and r arms are getting into that bit you intended for n only, and they have multiple amplifiers.

Comment by rhl [ 20/Oct/22 ]

Aargh. Yes. Thanks.

Comment by rhl [ 30/Oct/22 ]

Passed tests, merged, pushed

Generated at Sat Feb 10 16:02:40 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.