[PIPE2D-1096] Negative variance pixels are seen in n-band data Created: 18/Oct/22 Updated: 19/Oct/22 Resolved: 19/Oct/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | NIR | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Reviewers: | price | ||||||||
| Description |
|
price points out that there are non-positive variance pixels in the post-ISR exposure of, e.g. 45202 n2 (taken at LAM). Please fix this. |
| Comments |
| Comment by rhl [ 18/Oct/22 ] |
|
The simple fix is to support the maskNegativeVariance config parameter. But the real solution is to resolve PIPE2D-430 |
| Comment by rhl [ 18/Oct/22 ] |
| Comment by hassan [ 19/Oct/22 ] |
|
Change described in https://github.com/Subaru-PFS/obs_pfs/pull/132 looks fine. No additional comments. |
| Comment by hassan [ 19/Oct/22 ] |
|
Integration test passed. Ready for merging. |
| Comment by rhl [ 19/Oct/22 ] |
|
Merged and pushed |