[PIPE2D-1094] Organise H4RG defects by logical serial number (snX) not spectrograph number (nY) Created: 17/Oct/22  Updated: 03/Nov/22  Resolved: 18/Oct/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: NIR
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-1107 Integration test failing at defect in... Done
Reviewers: cloomis

 Description   

The mapping of H4RG device to final spectrograph is not yet known, and indeed the mapping is different at JHU and LAM.  Accordingly, we added sn names for the chips as follows:

sn serial arm at JHU arm at LAM arm at MKO
sn1 18315 n3 n2  
sn2 18660 n2    
sn3 18321      
sn4 18661      

The defects need to be arranged by sn number, not spectrograph number.  In order for this to be useful, the script that ingests them to be used in a calibration directory needs to be a little smarter:

  • copy $DRP_PFS_DATA_DIR/curated/pfs/defects/snX to StagingDirectory/nY with the mapping depending on the site
  • patch the header in the defects .ecsv files to map to the correct detector
  • Run ingestCuratedCalibs.py $TARGET --calib $TARGET/CALIB StagingDirectory --config clobber=True

While working on this ticket, we should add the serial to the metadata in the defects .ecsv files

 Comments   
Comment by rhl [ 17/Oct/22 ]

Not all that beautiful, but it seems to work.  The critical script is in obs_pfs and has a reasonably extensive description.  Basically, you need to setup the proper version of drp_pfs_data (i.e. one on this branch) and run a command like

TARGET=/projects/HSC/PFS/LAM
#rm -f $TARGET/CALIB/calibRegistry.sqlite3 
ingestPfsDefects --lam ~/sss/stagingArea $TARGET --calib $TARGET/CALIB --config clobber=True

You can specify the location of the defects on the command line instead if you prefer.

See

https://github.com/Subaru-PFS/drp_pfs_data/pull/21

https://github.com/Subaru-PFS/obs_pfs/pull/130

Comment by rhl [ 18/Oct/22 ]

Merged

Comment by hassan [ 29/Oct/22 ]

As Paul points out, the drp_pfs_data ticket branch has not been merged.

Comment by hassan [ 31/Oct/22 ]

Merged drp_pfs_data changes to master.

Generated at Sat Feb 10 16:02:37 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.