[PIPE2D-1092] Rotate H4 images Created: 15/Oct/22 Updated: 18/Oct/22 Resolved: 18/Oct/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | obs_pfs |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | price |
| Description |
|
The H4 detectors are physically rotated w.r.t. the CCDs: dispersion is along rows, with wavelength increasing from right to left. Geometry files should probably rotate them to match the CCDs. Presumably ISR tasks work on non-rotated images? Does coping with that take effort? |
| Comments |
| Comment by rhl [ 15/Oct/22 ] |
|
I can easily rotate the raw (post CDS) image. We'd have to rebuild the defects, but I think that that's the only place that it would have fallout at this point. Should I do this as part of |
| Comment by rhl [ 16/Oct/22 ] |
|
Actually it's easy to do this at the end of the isr, so I did. It looks as if we'll merge 668 today, so I'll push the changes tomorrow (2022-10-16) |
| Comment by rhl [ 16/Oct/22 ] |
|
N.b. price that'll mean that the DetectorMap is probably rotated from Jim's models. It's OK, we never use DetectorMaps on raw CCD data (because of the overscan etc.), so we still only need one map |
| Comment by rhl [ 17/Oct/22 ] |
| Comment by rhl [ 18/Oct/22 ] |
|
Merged to master |