[PIPE2D-1080] Use continuum in detectorMap adjustment whenever possible Created: 20/Sep/22  Updated: 07/Oct/22  Resolved: 05/Oct/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-1066 Handle inter-fiber optical crosstalk. Done
Sprint: 2DDRP-2022 F
Reviewers: hassan

 Description   

PIPE2D-1066 introduced the doForceTraces option, which has the code centroid on continuum and use those centroids as part of the detectorMap adjustment. However, this option needs to be activated explicitly, whereas we should default to using all information we can.

Change the default for this parameter, and check that it doesn't break anything (what happens when there's a lack of continuum?).

 Comments   
Comment by price [ 04/Oct/22 ]

Looks to be working just fine.

Comment by hassan [ 05/Oct/22 ]

Straightforward fix of changing the default parameter values (https://github.com/Subaru-PFS/drp_stella/pull/288) looks fine.

Comment by price [ 05/Oct/22 ]

Merged.

Generated at Sat Feb 10 16:02:27 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.