[PIPE2D-108] Create CalibTask to construct master Arc Created: 21/Oct/16  Updated: 08/Jun/17  Resolved: 08/Jun/17

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Major
Reporter: aritter Assignee: aritter
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PIPE2D-80 Task-ify code for creating normalized... Done
Relates
relates to PIPE2D-110 Please ignore emission lines with too... Won't Fix
Story Points: 0.5
Sprint: 2014-16
Reviewers: rhl

 Description   

We need to remove/mask cosmic rays in the Arc used for the wavelength calibration. The easiest way to do this is to create a CalibTask which combines multiple Arcs and masks cosmics if only one Arc is available.

 Comments   
Comment by aritter [ 26/Oct/16 ]

The error in reduceArc.py when calling the butler to find the calibration 'arc' file for an input dataId:

> /Users/azuri/stella-git/drp_stella/python/pfs/drp/stella/reduceArcTask.py(91)run()
-> arcExp = arcRef.get("arc", immediate=True)
reduceArcTask FATAL: Failed: 'ImageF' object has no attribute ‘setDetector'

was fixed by adding the function 'std_arc' to pfsMapper.py in analogy to 'std_bias', 'std_dark',...

Comment by aritter [ 28/Oct/16 ]

The code changes are in obs_pfs tickets/PIPE2D-108 and drp_stella tickets/PIPE2D-108. You need drp_stella_data tickets/PIPE2D-80 for the new files.
I disabled testing the wavelength calibration using the wavelengths predicted by the simulator for now as the new file containing these is still being worked on by Craig.

Comment by swinbank [ 22/Feb/17 ]

aritter — Could you rebase this against current master, please? It's pretty outdated as it stands. Sorry for the hassle.

Comment by aritter [ 21/Mar/17 ]

Rebased onto master

Comment by rhl [ 07/Jun/17 ]

OK to merge when white space changes are cleaned up.

Comment by aritter [ 08/Jun/17 ]

Merged into master

Generated at Sat Feb 10 15:48:32 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.