[PIPE2D-1057] Fix bootstrap's use of profile building Created: 06/Jul/22  Updated: 08/Jul/22  Resolved: 08/Jul/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: hassan

 Description   

Romain Philippe Lhoussaine ben brahim reports that bootstrapDetectorMap.py fails with the error:

TypeError: run() takes 2 positional arguments but 4 were given


 Comments   
Comment by price [ 06/Jul/22 ]

Confirmed that this fix works:

(lsst-scipipe-3.0.0) pprice@tiger2-sumire:~/pfs/drp_stella[tickets/PIPE2D-1057%] $ bootstrapDetectorMap.py /projects/HSC/PFS/Subaru --calib=/projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun price/pipe2d-1057 --flatId visit=45742 --arcId visit=45744 arm=r -c spatialOrder=1 spectralOrder=1 isr.doFlat=False
[...]
bootstrap.readLineList INFO: Filtered line lists, keeping species {'NeI'}.
bootstrap INFO: Found 457 lines in 10 traces
bootstrap INFO: Matched 407 lines
bootstrap INFO: Median difference from detectorMap: -0.890475,0.361361 pixels
bootstrap INFO: Fit 222/243 points, rms: x=0.057233 y=0.075490 total=0.048479 pixels
bootstrap INFO: Updating detectorMap...
bootstrap INFO: Median difference from detectorMap: -0.697037,0.462656 pixels
bootstrap INFO: Fit 131/164 points, rms: x=0.092005 y=0.063926 total=0.051254 pixels
bootstrap INFO: Updating detectorMap...
Comment by hassan [ 08/Jul/22 ]

No issue with the proposed changes.

Comment by price [ 08/Jul/22 ]

Merged.

Generated at Sat Feb 10 16:02:08 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.