[PIPE2D-1055] Fix weekly failure 2022-06-12 Created: 30/Jun/22 Updated: 13/Jul/22 Resolved: 13/Jul/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2022 E |
| Reviewers: | hassan |
| Description |
|
The weekly has been failing for a few weeks, right at the end in the verification phase: ====================================================================== FAIL: testObjects (__main__.ProductionTestCase_bmn) (catId=0, tract=0, patch='0,0', objId=144) Test that object files can be read, and they are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File "/scratch/pprice/jenkins/weekly/2022-06-12/build/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pfs_pipe2d/w.2022.24/python/pfs/pipe2d/weekly/test_weekly.py", line 95, in testObjects self.assertGreater(select.sum(), minFrac*len(spectrum), "Too many masked pixels") AssertionError: 7680 not greater than 7963.2 : Too many masked pixels |
| Comments |
| Comment by price [ 13/Jul/22 ] |
|
Found a few bugs in fitting the sky and flux calibration that were allowing NANs to proliferate. |
| Comment by hassan [ 13/Jul/22 ] |
|
Proposed changes in https://github.com/Subaru-PFS/drp_stella/pull/279 look fine to me. |
| Comment by price [ 13/Jul/22 ] |
|
Merged after running the weekly manually and verifying that the tests pass. |