[PIPE2D-104] Add Craig's pixel vs. wavelength file to datamodel and mapper Created: 19/Oct/16  Updated: 29/Oct/16  Resolved: 29/Oct/16

Status: Won't Fix
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Major
Reporter: aritter Assignee: aritter
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 1

 Description   

Craig's file containing the predicted wavelengths for each fiber and pixel needs to be added to the mapper so the butler can find it, and probably to the datamodel as well. reduceArcTask.py needs to be changed to access this file via the butler.



 Comments   
Comment by rhl [ 19/Oct/16 ]

Please add more details, and describe the point and contents of the file rather than referring to Craig.

Comment by aritter [ 20/Oct/16 ]

The file contains the predicted wavelength for each pixel in each FiberTrace. It is used to find the FiberId from the center position of the FiberTrace, and to get a preliminary line list for the wavelength calibration.

Comment by cloomis [ 20/Oct/16 ]

I can see generating a seed solution, with the slit and ccd at nominal position and focus.

But I think that any input list of line,lambda will need to be slightly stretched to best fit the measured peaks, and the 1-d trace of detected fiber centers will need to be correlated to the expected pattern for a given slit (also slightly shifted/scaled). [JEG has pointed out that the bounds of the fiber centers for the entire slit will be a good measure of focus.]

As a strawman how about two input files:

  • per-detector nominal wavelength map image. spLambdaMap-$arm-$spectrograph?
  • per-spectrograph slit map, enumerating the fibers along with their type, status (e.g. broken), known positions, etc.? spSlitMap-$spectrograph?
Comment by swinbank [ 20/Oct/16 ]

I'm confused, because Andreas seems to think this is a file that already exists and just needs appropriate handling, whereas Craig seems to be discussing the potential contents of two other (but related) files. Can somebody clarify?

Comment by aritter [ 21/Oct/16 ]

I have been using the existing but now outdated file in question for 2 different things:
1. to assign the fiberID to each FiberTrace based on the center positions of the FiberTrace on the CCD image,
2. to create a preliminary line list for the wavelength calibration from the predicted wavelengths for each row in the extracted FiberTrace.
Craig would (after discussion with Jim sensei) like to split this into 2 different files, one for the wavelengths and one for the fiber positions on the CCD. While this does make perfect sense, I think we should file a ticket to do this later and for now simply recreate the old file (if possible?) I was using as this is blocking me in PIPE2D-80.

Maybe Craig can comment on this further...

Comment by swinbank [ 29/Oct/16 ]

Obsoleted.

Generated at Sat Feb 10 15:48:29 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.