[PIPE2D-1021] Add executable that calls FitPfsFluxReferenceTask Created: 11/Apr/22 Updated: 06/Jun/22 Resolved: 13/Apr/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | sogo.mineo | Assignee: | sogo.mineo |
| Resolution: | Done | Votes: | 0 |
| Labels: | flux-calibration | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | flux calibration |
| Reviewers: | price |
| Description |
|
FitPfsFluxReferenceTask does not write its result object. There should be something like calculateReferenceFlux.py, which calls FitPfsFluxReferenceTask and writes the returned object. |
| Comments |
| Comment by sogo.mineo [ 11/Apr/22 ] |
|
I don't think of a good reason to make a separate task that wraps FitPfsFluxReferenceTask. I am to convert FitPfsFluxReferenceTask itself into an executable if it is possible. |
| Comment by price [ 11/Apr/22 ] |
|
Sounds good. |
| Comment by sogo.mineo [ 12/Apr/22 ] |
|
Could you review these two PRs? The added executable (bin/fitPfsFluxReferenceTask.py) does not run successfully if I input the files of the integration test, because the task requires two or more broad-band fluxes for FLUXSTD spectra. However, the validity of the whole code except for file IO is tested by the unit test (which is left unchanged), and I have made sure by experiments that the output file would actually be written through the butler if the instruction pointer were to arrive at dataRef.put(...). |
| Comment by sogo.mineo [ 13/Apr/22 ] |
|
Merged. Thanks for the review. |