[PIPE2D-1010] reduceExposure fails with PFI calib and continuum subtraction Created: 23/Mar/22  Updated: 30/Mar/22  Resolved: 30/Mar/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: hassan Assignee: hassan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 1
Sprint: 2DDRP-2022 C
Reviewers: price

 Description   

This is a follow-on from PIPE2D-993.

When running reduceExposure from weekly w.2022.10 using SuNSS-based visits, against the calib CALIB-PFI-20211220 with continuum subtraction enabled:

reduceExposure.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun=hassans/sunss/v71290_46588_pfi_20220322h --d
oraise --id visit=46588^71290 arm=b^r -c isr.doApplyGains=True isr.doFlat=False isr.doWrite=True doSubtractSky2d=False photometerLines.doApertureCorrection=False doSubtractContinuum=True

Fails with the following error:

File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.10/python/pfs/drp/stella/reduceExposure.py", line 306, in runDataRef
maskedImage -= continua.makeImage(exposure.getBBox(), fiberTraces)
File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.10/python/pfs/drp/stella/SpectrumSetContinued.py", line 212, in makeImage
spec = self[fiberIds.index(ft.fiberId)]
ValueError: 2 is not in list

 Comments   
Comment by hassan [ 23/Mar/22 ]

Error is similar to the 'book-keeping' error reported in PIPE2D-993. In this case, the FiberProfile contains additional fiberIds than specified in the corresponding PfsConfig file. However, the code assumes that all fibers that listed in the FiberProfile are in the PfsConfig file.

Comment by hassan [ 30/Mar/22 ]

Merged to master

Generated at Sat Feb 10 16:01:23 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.