[PIPE2D-1008] Confirm units of pfsArm flux are electrons/pixel and pfsMerged electrons/nm Created: 23/Mar/22 Updated: 20/May/23 Resolved: 20/May/23 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | arnaud.lefur |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Story Points: | 4 | ||||||||||||||||
| Sprint: | 2DDRP-2022 C, 2DDRP-2022 D, 2DDRP-2022 E, 2DDRP-2022 F | ||||||||||||||||
| Description |
|
The expected units for the pfsArm is electrons per pixel and pfsMerged files are electrons per nanometre. Please go step by step through the 2D DRP code and products, from the raw exposures to the pfsArm and pfsMerged files to confirm that the units of the latter two products are as expected. Please document the details of each step in this ticket. This is important in general |
| Comments |
| Comment by price [ 23/Mar/22 ] |
|
Units will not be electrons per nm with the code as it currently is. Note that "The expected units for the pfsArm and pfsMerged files are electrons per nanometre." is not specified in datamodel.txt. Rather, the flux units of pfsArm explicitly called out to be "counts". |
| Comment by rhl [ 23/Mar/22 ] |
|
This is about the overall throughput, not the b/r discrepancy. Paul's comments are correct, but the comparison is still valid. We should be able to interpret the numbers in the pfsArm/pfsMerged files in terms of electrons/nm (and how to do so should be in the datamodel). |
| Comment by arnaud.lefur [ 30/Mar/22 ] |
|
So I spend a bit of time looking into this. on the red arm: on the blue arm: Anyhow, from what I'm seeing, I confirm Paul statement, the pfsArm fluxes are in counts (or electrons if doApplyGains). Regarding, pfsMerged : |
| Comment by rhl [ 31/Mar/22 ] |
|
Looks good, but I'm still slightly confused. You're plotting the pfsArm files against wavelength, but not applying a Jacobian, so are you really plotting per row, but labelling the rows with the corresponding wavelength? What happened with 477 in the blue? A bad detector map everywhere? Which rerun/calib are you using for this work? In the pfsMerged files, the units should be electrons/nm which is easy to think about away from the dichroics. Is this what you observe? What is the factor of c. 12 coming from? pixels to nm? |
| Comment by arnaud.lefur [ 31/Mar/22 ] |
|
You're plotting the pfsArm files against wavelength, but not applying a Jacobian, so are you really plotting per row, but labelling the rows with the corresponding wavelength? What happened with 477 in the blue? A bad detector map everywhere? Which rerun/calib are you using for this work? In the pfsMerged files, the units should be electrons/nm which is easy to think about away from the dichroics. Is this what you observe? What is the factor of c. 12 coming from? pixels to nm? right, I just divided the pfsArm flux (e-/row) by the spectral resolution (nm/row) (or multiplied by this curve |
| Comment by rhl [ 31/Mar/22 ] |
|
We should get to the bottom of fibre 6 (sorry, I mis-read the legend). It could be a problem in the fiberTrace or the normalisation or ... The dropouts matter too. This is not unrelated to I still don't understand the pfsMerged case. The fluxes should be in e/nm and your values should agree with the pfsMerged everywhere except where the dichroic matters. So the blue and red side should agree, and not have any structure with lambda or arm. price: what am I missing? |