[PIPE1D-71] Update for drp1d 0.42.0 Created: 16/Jun/23  Updated: 11/Jan/24  Due: 19/Jun/23  Resolved: 11/Jan/24

Status: Done
Project: DRP 1D pipeline
Component/s: drp_1dpipe
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: Ali Allaoui Assignee: Ali Allaoui
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: Kiyoto Yabe

 Comments   
Comment by Kiyoto Yabe [ 22/Jun/23 ]

Sorry, it took some time. I didn't notice the new requirements on `eigen` and `lbfgspp` ...

I checked installation of the new version, but could you fix

https://github.com/Subaru-PFS/drp_1dpipe/blob/tickets/PIPE1D-71/drp_1dpipe/__init__.py

to the newer version.

After fixing this, the installation was successful.

The validation failed but it seems that D1DP_VER=0.40.0 in the validation products, so this may cause the failure. Could you check this as well please?

Comment by Ali Allaoui [ 23/Jun/23 ]

Apologize for not telling you about the new requirements.

I updated version number of drp1d_pipe and merged PIPE1D-71 into master, and also updated the datapack with the correct version number. Everything should be in order now

Comment by Kiyoto Yabe [ 24/Jun/23 ]

Thank you for the update! The installation is now OK.

I see some difference in the validation. Mostly very tiny numerical difference but this time I see this.

(lsst-scipipe-3.0.0) bash-4.2$ fitsdiff pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits ../../validation/data/pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits fitsdiff: 4.1
 a: pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits
 b: ../../validation/data/pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits
 Maximum number of different data values to be reported: 10
 Relative tolerance: 0.0, Absolute tolerance: 0.0Primary HDU:   Headers contain differences:
     Keyword GALAXY_LWARNING has different values:
        a> 8388608
        b> 0

I'll take a look closer and I will try to think about how to reproduce in your side. 

Comment by Ali Allaoui [ 26/Jun/23 ]

Can you send me the test_output directory so I can check differences and log ?

These differences can be normal, including the change in the line measurement warning flag, as the new line flux measurement algorithm is very sensitive

Comment by Kiyoto Yabe [ 27/Jun/23 ]

Thanks! I put the directory here:

https://pfs.ipmu.jp/internal/devarch/ipmu/tmp/test_output/

Now I see some internal errors in the log, which were not seen during the processing.

Comment by Kiyoto Yabe [ 11/Jan/24 ]

Now the validation problem is discussed in a different ticket, so this ticket will be closed.

Generated at Thu Apr 24 15:23:48 JST 2025 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.