[PIPE1D-7] Investigate LINENAME content in output FITS file Created: 19/Feb/19 Updated: 11/Sep/20 Resolved: 11/Sep/20 |
|
| Status: | Done |
| Project: | DRP 1D pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | Pierre-Yves CHABAUD | Assignee: | Pierre-Yves CHABAUD |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Description |
|
Satoshi TAKITA raised an issue concerning the content of LINENAME field inside the output FITS file. Satoshi TAKITA, on 02/14/19 I cannot recognize the LINENAME. It says as b'((\xa8\xc6\xab\x7f'. What kind of names will be stored in this column? |
| Comments |
| Comment by Pierre-Yves CHABAUD [ 20/Feb/19 ] |
|
takita : the LINENAME field was not fed in your software version, so the content should not be interpreted. It's solved and will be part of the next release. Thank you for having raised it. Is it a blocking point and do you want a fix for your version ? or could you wait for next release (next week) ? (honestly I prefer last one |
| Comment by takita [ 20/Feb/19 ] |
|
OK, there's no need to rush. I wait the next release. |
| Comment by takita [ 22/Aug/19 ] |
|
Although the new pipeline was not yet working at NAOJ, I have checked the sample output files (pfs_datapack_sp8), and found another problem about 'LINENAME'. This field was defined as "TFORM = 15A", but this was not enough to describe the full line name, like '[OIII] (double-foo)' (see attached image). However, I prefer using short name like 'oiii_4959' which was used in SDSS. Here is what I'm thinking about line names. |
| Comment by Pierre-Yves CHABAUD [ 27/Aug/19 ] |
|
Ok, I get. Idealy it could be nice to change the line names in the dedicated calibration file, but I expect side effects. So, in short time, I will match simply our line names with SDSS ones at the end of processing ( i.e. writing product) |
| Comment by Kiyoto Yabe [ 18/Aug/20 ] |
|
In the latest pipeline, it looks that the lines are still like this: |