[INSTRM-936] Have oneCmd.py set exit code on command failures. Created: 31/Mar/20 Updated: 31/Mar/20 Resolved: 31/Mar/20 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | tron_actorcore |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The oneCmd.py script needs to exit(1) on command failures. I don't want useless python output, so will call os._exit(). Wish they had a cleaner way. |
| Comments |
| Comment by rhl [ 31/Mar/20 ] |
|
I'd consider a --doRaise or similar option for those times that you do want the traceback. |
| Comment by cloomis [ 31/Mar/20 ] |
|
Generally I'd agree. In this case there is no useful information left, and the traceback would simply be that SystemExit was raised. Regular failures always get a traceback – I should make that controllable with --doRaise. |
| Comment by cloomis [ 31/Mar/20 ] |
|
Merged at eaa034a, tagged 2.1.6 There does need to be better control of output and exits. Other tickets. |
| Comment by cloomis [ 31/Mar/20 ] |
|
Corrected a stupid mistake. Merged at 9e4c068, tagged 2.1.7 |