[INSTRM-920] add a success criteria for motor test (fpaRange) Created: 12/Mar/20  Updated: 21/Oct/21

Status: Open
Project: Instrument control development
Component/s: ics_testsActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: fmadec Assignee: cloomis
Resolution: Unresolved Votes: 0
Labels: SPS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 5
Sprint: SM1PD-2020 J, SM1PD-2020 M, SM1PD-2020 N, SM1PD-2021 A, SM1PD-2021 A 2, SM1PD-2021 A 3, SM1PD-2021 A 4, SM1PD-2021 A 5, SM1PD-2021 A 6, SM1PD-2021 A7, SM1PD-2021 A8, SM1PD-2021 A9, SM1PD-2021 A10, SM1PD-2021 A 11, SM1PD-2021 A 12, SM1PD-2021 A 13, SM1PD-2021 A 14

 Description   

I think we should add a success criteria for the fpaRange test of the focus motors.

this could be based on the fact that the full travel is done: the 2 switches were pushed during the full travel move.

this could be also done on a criteria the range itself, like greater than xxx microns. one issue is that the Blue and Red range is not the same. (even if a recent bug was discovered and we will confirm that on  B2 at LAM).

 

 Comments   
Comment by hassan [ 05/Dec/20 ]

Craig to contact Josh Peebles for success criteria.

Comment by hassan [ 16/Jan/21 ]

Craig will start with assuming the SM1 range is sufficient.

Comment by cloomis [ 16/Jan/21 ]

Josh reports that the limits are set to 308 +/- 5um. Will check existing camera ranges to see whether they would all pass.

Comment by fmadec [ 08/Mar/21 ]

I will need to report on other CU, but just tested b3 and ranges are:

  • motor A: 285.6µm
  • motor B: 314.9µm
  • motor C: 308.7µm
Comment by hassan [ 25/Mar/21 ]

Fabrice will also check the measurements on r3.

Comment by fmadec [ 31/Mar/21 ]

R3:

 

2021-03-31T14:20:23.814 sent tests fpaMotors findRange cam=r3 (from fmadec_PFS_WS2)
2021-03-31T14:20:23.825 tests i text="connecting model for actor xcu_r3"
2021-03-31T14:20:23.862 tests i text="fpa findRange: initializing and homing motors."
2021-03-31T14:20:32.538 tests i text="fpa findRange: driving past far limit."
2021-03-31T14:20:44.644 tests i text="pastFar: 1 0 1 3303 304.89"
2021-03-31T14:20:44.644 tests i text="pastFar: 2 0 1 3442 324.82"
2021-03-31T14:20:44.644 tests i text="pastFar: 3 0 1 3324 313.35"
2021-03-31T14:20:45.646 tests i text="fpa findRange: inching off far limit."
2021-03-31T14:21:23.030 tests i text="offFar: 1 0 0 3246 299.47"
2021-03-31T14:21:23.030 tests i text="offFar: 2 0 0 3357 316.56"
2021-03-31T14:21:23.031 tests i text="offFar: 3 0 0 3234 304.60"
2021-03-31T14:21:23.032 tests i text="fpa findRange: driving motors back to near home switch"
2021-03-31T14:21:34.681 tests i text="nearHome: 1 0 0 125 2.38"
2021-03-31T14:21:34.682 tests i text="nearHome: 2 0 0 125 2.43"
2021-03-31T14:21:34.682 tests i text="nearHome: 3 0 0 125 2.43"
2021-03-31T14:21:34.682 tests i text="fpa findRange: inching onto home switch."
2021-03-31T14:21:50.623 tests i text="onHome: 1 1 0 98 -0.16"
2021-03-31T14:21:50.623 tests i text="onHome: 2 1 0 100 0.01"
2021-03-31T14:21:50.623 tests i text="onHome: 3 1 0 98 -0.12"
2021-03-31T14:21:50.624 tests i text="fpa findRange: homing motors."
2021-03-31T14:21:56.574 tests i fpamotorsovershoot=r3,56,84,89
2021-03-31T14:21:56.574 tests : fpamotorsrange=r3,3147,3256,3135,298.63,315.55,303.72

 

Comment by fmadec [ 31/Mar/21 ]

B3 again:

2021-03-31T14:28:02.668 sent tests fpaMotors findRange cam=b3 (from fmadec_PFS_WS2)
2021-03-31T14:28:02.674 tests i text="fpa findRange: initializing and homing motors."
2021-03-31T14:28:11.220 tests i text="fpa findRange: driving past far limit."
2021-03-31T14:28:23.484 tests i text="pastFar: 1 0 1 3203 295.37"
2021-03-31T14:28:23.485 tests i text="pastFar: 2 0 1 3436 324.21"
2021-03-31T14:28:23.485 tests i text="pastFar: 3 0 1 3281 309.18"
2021-03-31T14:28:24.488 tests i text="fpa findRange: inching off far limit."
2021-03-31T14:29:02.901 tests i text="offFar: 1 0 0 3138 289.19"
2021-03-31T14:29:02.901 tests i text="offFar: 2 0 0 3350 315.85"
2021-03-31T14:29:02.902 tests i text="offFar: 3 0 0 3190 300.34"
2021-03-31T14:29:02.902 tests i text="fpa findRange: driving motors back to near home switch"
2021-03-31T14:29:14.965 tests i text="nearHome: 1 0 0 125 2.38"
2021-03-31T14:29:14.965 tests i text="nearHome: 2 0 0 125 2.43"
2021-03-31T14:29:14.966 tests i text="nearHome: 3 0 0 125 2.43"
2021-03-31T14:29:14.966 tests i text="fpa findRange: inching onto home switch."
2021-03-31T14:29:30.375 tests i text="onHome: 1 1 0 98 -0.11"
2021-03-31T14:29:30.376 tests i text="onHome: 2 1 0 99 -0.07"
2021-03-31T14:29:30.376 tests i text="onHome: 3 1 0 99 -0.06"
2021-03-31T14:29:30.376 tests i text="fpa findRange: homing motors."
2021-03-31T14:29:36.327 tests i fpamotorsovershoot=b3,64,85,90
2021-03-31T14:29:36.327 tests : fpamotorsrange=b3,3039,3250,3090,288.30,314.92,299.40
Comment by fmadec [ 31/Mar/21 ]

According my integration notes for B1:
motor B : 312µm
motor A:  281µm

This one was tuned by LAM ( not the following CUs which were made by JHU)

Comment by fmadec [ 21/May/21 ]

R2 results are weird

 

2021-05-20T15:53:40.741 sent tests fpaMotors findRange cam=r2 (from fmadec_PFS_WS2) 
2021-05-20T15:53:40.840 tests i text="fpa findRange: initializing and homing motors." 
2021-05-20T15:54:10.689 tests i text="fpa findRange: driving past far limit." 
2021-05-20T15:54:28.278 tests i text="pastFar: 1 0 1 3812 353.41" 
2021-05-20T15:54:28.278 tests i text="pastFar: 2 0 1 4018 380.71" 
2021-05-20T15:54:28.279 tests i text="pastFar: 3 0 1 3700 349.82" 
2021-05-20T15:54:29.280 tests i text="fpa findRange: inching off far limit." 
2021-05-20T15:55:07.680 tests i text="offFar: 1 0 0 3734 345.98" 
2021-05-20T15:55:07.680 tests i text="offFar: 2 0 0 3919 371.09" 
2021-05-20T15:55:07.682 tests i text="offFar: 3 0 0 3610 341.07" 
2021-05-20T15:55:07.683 tests i text="fpa findRange: driving motors back to near home switch" 
2021-05-20T15:55:20.713 tests i text="nearHome: 1 0 0 125 2.38" 
2021-05-20T15:55:20.714 tests i text="nearHome: 2 0 0 125 2.43" 
2021-05-20T15:55:20.715 tests i text="nearHome: 3 0 0 125 2.43" 
2021-05-20T15:55:20.715 tests i text="fpa findRange: inching onto home switch." 
2021-05-20T15:55:36.853 tests i text="onHome: 1 1 0 99 -0.03" 
2021-05-20T15:55:36.854 tests i text="onHome: 2 1 0 99 -0.06" 
2021-05-20T15:55:36.855 tests i text="onHome: 3 1 0 98 -0.11" 
2021-05-20T15:55:36.855 tests i text="fpa findRange: homing motors." 
2021-05-20T15:55:42.717 tests i fpamotorsovershoot=r2,77,98,89 
2021-05-20T15:55:42.718 tests : fpamotorsrange=r2,3634,3819,3511,345.01,370.15,340.18

the range is much bigger .... but I am much warmer because I am doing defocus test...

Generated at Sat Feb 10 16:30:00 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.