[INSTRM-737] Implement correct visitId/frameId logic for the FPS/MCS system. Created: 22/Aug/19 Updated: 27/Aug/19 Resolved: 27/Aug/19 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_fpsActor, ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Description |
|
ics_mcsActor is currently commanded directly by Gen2, so self-allocates frameIds. It has no context about its exposures (how many are being taken, etc.) so wastefully allocates full 100-frame visits for each frame. When we switch to ics_fpsActor control, that will be able to fetch/receive a visit and tell the mcsActor about the individual frames within that. Implement this. The only trick is that in operation, the fpsActor itself will be told what the active visit is. But that is pretty minor. |
| Comments |
| Comment by cloomis [ 26/Aug/19 ] |
|
We are implementing an ics_iicsActor, which is by design the main consumer of visits from Gen2, and which passes those visits down to the fpsActor, spsActor, and agccActor}}s. So in this case it will be the {{iicActor which does the allocation. |
| Comment by cloomis [ 27/Aug/19 ] |
|
ics_iicActor merged at bac8542, tagged 1.0.0, installed Basically, there is a iic fpsLoop cnt=N command which controls the fps testLoop command, which in turn commands individual ics expose commands. Unlikely to be finished, but is functional enough to hand back for other FPS work. Please note, chyan |