[INSTRM-727] Add broken cobra handling to the pfiDesign object. Created: 02/Aug/19 Updated: 23/Feb/23 Resolved: 23/Feb/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_cobraCharmer |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | CanBeClosed, PFI, cit_freeze | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Description |
|
Broken cobra tracking is currently ad-hoc (lists in code). We should load those into the pfiDesign object, since that is what tracks the configuration of the modules. We could do this in two ways. There is a status field (unused?) in the XML file, which would keep all arm/module info in one file (good!). Or we could persist into a/the per-module YAML file in pfs_instdata. Inclined to use the status field for now; will look for any existing usage. Will branch this off cit_freeze. |
| Comments |
| Comment by cloomis [ 14/Aug/19 ] |
|
Went for using the XML Status field. That is currently always 1, indicating a good cobra. For backward compatibility, will keep bit 0 as indicating that the cobra is fully OK or not. And am adding, for now:
Chi-Hung has ideas for more bits, but those two cover the current issues. The PfiDesign object has grown accessors (.getGoodCobraMask(), etc), and a method to set a cobra's status. |
| Comment by yuki.moritani [ 23/Feb/23 ] |
|
As of 2023 Feb, the broken cobras were listed in xml file, and branches were merged. |