[INSTRM-644] Make sure that the ICC stop() functions deallocate internal hardware resources if they can. Created: 05/Apr/19  Updated: 04/Jul/19

Status: Open
Project: Instrument control development
Component/s: ics_ccdActor, ics_xcu_fpga
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: cloomis
Resolution: Unresolved Votes: 0
Labels: SPS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 2

 Description   

When disconnect (and thus connect, too) is called on a controller, the Controller's stop() routine is called before the reference is deleted. In most cases that does nothing, and the deallocation clears things up.

In some cases, the actor needs to be more careful. If there is any chance that a controller can fail to release some hardware resource or fail to be freed it can be hard to recover. Among other things there is no longer any reference to the python object, so you cannot hit it harder later. You have to make sure it is closed up before deleting the reference.

This ticket specifically applies to the fee and fpga/ccd controllers in ics_ccdActor. But actually might apply to all actors which hold hardware controllers. Please think it over, arnaud.lefur



 Comments   
Comment by arnaud.lefur [ 05/Apr/19 ]

 That's a good point and I think i'm not careful enough ...

Generated at Sat Feb 10 16:27:10 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.