[INSTRM-632] Allow stopping ramps from actor Created: 16/Mar/19  Updated: 16/Apr/23  Resolved: 16/Apr/23

Status: Done
Project: Instrument control development
Component/s: hxhal, ics_hxActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: cloomis Assignee: cloomis
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks INSTRM-1566 Backpatch some PHDU cards after ramp ... Done
Relates
relates to INSTRM-1887 Preparation of the summit system for ... Done
Story Points: 2
Sprint: PreEng11Apr1

 Description   

Ramp reads stop cleanly from inside the hxhal module, but we have no way to make that happen from the actor. Add. [slightly tricky because we will have to run the reads in an interruptible thread. ]



 Comments   
Comment by cloomis [ 12/Apr/23 ]

For the benefit of iic, the command is ramp finish [<exptime>] [<obstime>] [@stopRamp] We are merging the ramp stop command with a new ramp finalization command to avoid mistakes. Basically, whether or not the ramp is to be stopped the hxActor needs to be told what the real exposure times are.

Comment by cloomis [ 15/Apr/23 ]

The time card backpatching is blocked by a one line bug in the underlying fitsio module. A pull request has been submitted, but I suspect Erin will not cut a new version immediately. Not sure how best to handle this for us. We could install a new version in our conda trees?

Comment by arnaud.lefur [ 15/Apr/23 ]

I guess we have to.

Comment by cloomis [ 15/Apr/23 ]

A simple python setup.py install did not quite do it. The new version installed, but did not get linked in as the canonical fitsio module. So built a conda package to get around that, which I think will be OK. I do need to test a bit, since installing from .pkg files implies -no-deps, and the .pkg had to be built in a nonrubin-ics conda env.

LSST doubtless has the right mechanism to do this, but likely require a boatload of custom machinery.

Comment by arnaud.lefur [ 15/Apr/23 ]

the spsActor part of it bas been implemented and tested with the hx simulator.
Note that those new commands hasn't actually been added to the simulator, but I can check that commands are issued and their timing.
This now needs to be tested on real hardware.

Comment by cloomis [ 16/Apr/23 ]

Requires:

hxhal                 3.1.0
ics_hxActor       2.7.1
ics_utils             1.7.0
Generated at Sat Feb 10 16:27:02 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.