[INSTRM-619] Ingest failed for medium resolution bias images Created: 28/Feb/19  Updated: 06/Mar/19  Resolved: 06/Mar/19

Status: Done
Project: Instrument control development
Component/s: ics_ccdActor
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: fmadec Assignee: cloomis
Resolution: Done Votes: 0
Labels: SM1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: Red channel alignment

 Description   

We did some tests with medium resolution grating this week, but ingest failed for the biases

 

2019-02-27 14:56:27.834Z cmds             20 Actor.py:499 new cmd: ingest filepath=/data/pfs/pfs/2019-02-27/PFLA01292114.fits
2019-02-27 14:56:27.835Z cmds             20 Actor.py:499 new cmd: detrend filepath=/data/pfs/pfs/2019-02-27/PFLA01292114.fits
root INFO: Loading config overrride file '/opt/lsst/software/stack/stack/miniconda3-4.3.21-10a4fa6/Linux64/obs_pfs/c8f11eeeb3a5bdafc8f16fb33da301cab319a441/config/ingest.py'
CameraMapper INFO: Loading exposure registry from /drp/m1/registry.sqlite3
ingest.parse WARN: Unable to find value for dataType (derived from IMAGETYP)
ingest.parse WARN: Unable to find value for expTime (derived from EXPTIME)
ingest.parse WARN: Unable to find value for dateObs (derived from DATE-OBS)
ingest.parse WARN: Unable to find value for taiObs (derived from DATE-OBS)
ingest.parse WARN: translate_field failed to translate field: IMAGETYP not found
ingest.parse WARN: translate_date failed to translate dateObs: DATE-OBS not found
ingest.parse WARN: translate_date failed to translate taiObs: DATE-OBS not found
ingest WARN: Failed to ingest file /data/pfs/pfs/2019-02-27/PFLA01292114.fits: No locations for get: datasetType:raw_filename dataId:DataId(initialdata={'site': 'L', 'category': 'A', 'visit': 12921, 'filter': 'm', 'arm': 'm', 'spectrograph': 1, 'ccd': 1, 'pfsConfigId': 0, 'slitOffset': 0.0}, tag=set())
2019-02-27 14:56:28.329Z cmds             20 CommandLink.py:121 > 1 753 i text='None'
2019-02-27 14:56:28.329Z cmds             20 CommandLink.py:121 > 1 753 : ingest=/data/pfs/pfs/2019-02-27/PFLA01292114.fits'
2019-02-27 14:56:28.341Z cmds             20 CommandLink.py:121 > 1 754 f text="command failed: KeyError(\"Keyword 'DATE-OBS' not found.\",) at /opt/lsst/software/stack/python/miniconda3-4.3.21/lib/python3.6/site-packages/astropy/io/fits/header.py:1675"

it looks like these keywords are missing for the biases image, so it may not be a DRP related issue

 

 



 Comments   
Comment by cloomis [ 28/Feb/19 ]

Confirmed.

Comment by arnaud.lefur [ 06/Mar/19 ]

I made a test with B1:

I've started ics_ccdActor:1.3.8 and took a bias, those keys are missing indeed.

so, we're currently running 1.3.6, header is fine ( W_VISIT excepted)

Comment by cloomis [ 06/Mar/19 ]

How hard would it be to use the same wipe, read exptype sequence used for arc/flat/object exposures for bias and dark exposures? I don't think that the bias and darks commands can work in the long run. Convenient in the lab, but not sustainable.

Comment by arnaud.lefur [ 06/Mar/19 ]

The visitId would also be parsed in the read command ?

Not hard, but that require a bit of refactoring.

Comment by cloomis [ 06/Mar/19 ]

The carrot is that the caller (you) would always use the same mechanism to take all exposures: wipe followed by read exptype visit=NNN etc. One way or the other the visit must be passed in, since the ccdActor will not be able to know what visit to use.

Comment by arnaud.lefur [ 06/Mar/19 ]

right, that's coherent.

My only concern is about biases, is the command flow fast enough ? you might have a 0.05s dark instead.

Comment by cloomis [ 06/Mar/19 ]

Merged at 9dfba69, tagged 1.3.9

Generated at Sat Feb 10 16:26:54 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.