[INSTRM-606] Generate {{W_PFDSGN}} FITS card at LAM Created: 08/Feb/19 Updated: 26/Feb/19 Resolved: 26/Feb/19 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_dcbActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | arnaud.lefur |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
In order for the DRP to know which fibers are illuminated at LAM, it needs the id of a PfsDesign. At Subaru, this will come from the fpsActor; I think the sensible equivalent for LAM is the dcbActor, since that is the closest code to the fiber bundles and their illumination. We (DRP) will make {{PfsDesign}}s for the named fiber groups which we know about ("orange", "red1", etc.), and price will either provide a function for making a hex ID from a list of names, or a dictionary of IDs. Can the dcbActor arrange to generate a keyword for that ID ("designId", maybe?), with the FITS card being (W_PFDSGN, PFS_DESIGN_ID)? I think we want a Long keyword because the values will be 16 hex digits long. |
| Comments |
| Comment by price [ 08/Feb/19 ] |
|
I've added some functions in |
| Comment by cloomis [ 08/Feb/19 ] |
|
Looks nice to me.... |
| Comment by arnaud.lefur [ 14/Feb/19 ] |
|
yes, I could use that. It would mean that dcbActor needs to know about datamodel and drp_stella. So we need to make ics and drp world cohabitate again. docker ?
|
| Comment by arnaud.lefur [ 20/Feb/19 ] |
|
no need for this complexity. I'm directly using price script. The keyword is generated and successfully added to the header : PFLA01250512.fits W_PFDSGN= 4296015889
|
| Comment by cloomis [ 20/Feb/19 ] |
|
I'm happy. Thanks. |