[INSTRM-554] Toughen {{canonexp}} camera controller and pass errors back to caller. Created: 24/Oct/18 Updated: 24/Oct/18 Resolved: 24/Oct/18 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_mcsActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | MCS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Description |
|
While switching back and forth between users and programs during initial engineering, we left a canonexp /tmp file owned by a non-fps user and non-group writable. This caused canonexp to segfault. This can easily be hardened: open("/tmp/cameradump.raw", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 EACCES (Permission denied)
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0} ---
|
| Comments |
| Comment by cloomis [ 24/Oct/18 ] |
|
Merged in 018d838, tagged 1.4.6. Only made canonexp survive a bad file with a stderr complaint. |