[INSTRM-55] [xcuActor] controller input buffering can get out of step Created: 27/Dec/16 Updated: 19/Dec/19 |
|
| Status: | Open |
| Project: | Instrument control development |
| Component/s: | ics_xcuActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | SM1, SPS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 4 |
| Description |
|
This issue was initially filed into JIRA by 'cloomis' at 17/Mar/16 2:38 PM as ICS-26. Some XCU devices return line-delimited input, and the actor controllers consume input line-by-line. The current control flow expects the devices to be well behaved, and not to return extra or unexpected information. If extra lines are received they are buffered, and will be returned to later commands. This is wrong, fragile, and dangerous. There should always be a listener so that when a device blurts out junk or reboots the output is consumed and reported. [ I usually do this correctly, but hoped that I could come up with a better implementation before the actor was finalized. ] |
| Comments |
| Comment by hassan [ 18/Jan/19 ] |
|
Needs to be fixed before shipping to Subaru (~ July 2019), but not urgent earlier than that. |
| Comment by hassan [ 19/Dec/19 ] |
|
This can remain in backlog |