[INSTRM-528] Constrain PFS kansoku script directories to allowed FITS.PFS.OBS-MOD values. Created: 17/Oct/18 Updated: 19/Sep/21 Resolved: 18/Sep/21 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | PFS_kansoku |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | yuki.moritani |
| Resolution: | Done | Votes: | 0 |
| Labels: | FITS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The FITS OBS-MOD card is filled in from the kansoku sk sub-directory names. We have been using that to indicate "ENG"ineering. Turns out that values are limited to those negotiated with NOAJ We need to work this out. |
| Comments |
| Comment by hassan [ 17/Oct/18 ] |
|
cloomis should this issue have the MCS label? |
| Comment by cloomis [ 27/Aug/19 ] |
|
In the v7.0 NAOJ FITS bible, Sections 9.1 and 10.1 address OBS-MOD values and thus (as I understand it) possible sk directory names. Do we need to change the directory names to "IMAG" for some scripts and "SPEC" for others? Not sure I understand. Hisanori Furusawa? |
| Comment by yuki.moritani [ 27/Aug/19 ] |
|
I'm sorry I didn't noticed The book claim that you can put anything by putting "_" after allowed words. Following it, I'd propose "SPEC_ENG". (PFS has only spectrograph mode, so I think we should keep SPEC to every images.) |
| Comment by Hisanori Furusawa [ 29/Aug/19 ] |
|
cloomis Basically, yes. The abstract commands should be grouped separately for imaging and spectrograph modes so that the corresponding skeleton files are located under relevant directories that are named one of IMAGE(_*), SPEC(*), IPOL(*), and SPOL(_*). There are some exceptions with the existing instruments due to some historical reason (in some cases, the rule was simply overlooked unfortunately), and now Gen2 & FITS teams at the observatory are figuring out how to mitigate those violations on the Gen2 code side. This is an undesired exception handling, so we want to avoid this as much as possible with the active and future instruments. |
| Comment by yuki.moritani [ 29/Aug/19 ] |
|
Hisanori Furusawa , thank you for telling the background. Then, as long as we start with SPEC_ , ** is there no other convention to follow? (I thing yes, reading FITS bible ver 7.0.). I will change PFS kansoku scripts accordingly after our run this week.
|
| Comment by Hisanori Furusawa [ 29/Aug/19 ] |
|
To my understanding, there is no other mandatory convention, as long as a registered value is used for consistently the same meaning. There might be some offline discussion of a practical convention recently. I hope monodera could comment on this. |
| Comment by eric [ 29/Aug/19 ] |
|
You can also put a special assignment in the header of an observation script to override the directory name so that the FITS.PFS.OBS-MOD will be set correctly. We added that for some of the older instruments who had used "non-standard" directory names (e.g. "LAUNCHER", "ENG", etc.)
|
| Comment by monodera [ 30/Aug/19 ] |
|
As long as the OBS-MOD starts with one of "IMAGE", "SPEC", "IPOL", and "SPOL" followed by "_", there is no particular convention. "SPEC_ENG" meets the regulation but it looks to me too generic as one cannot distinguish whether the data are for engineering for MCS, SM, other modules, or even combination of more than one. On the other hand, making different OBS-MOD for different types of engineering (e.g, SPEC_ENG_MCS, SPEC_ENG_SM1, etc) could be even more complicated. For example, SMOKA lists some details of engineering observations (https://smoka.nao.ac.jp/ENG/ENGschedule.jsp). It would be helpful if PFS can do the same, while just using "SPEC_ENG" for OBS-MOD. |
| Comment by yuki.moritani [ 23/Jul/21 ] |
|
(For recording) |
| Comment by yuki.moritani [ 18/Sep/21 ] |
|
I tested the new commands during the engineering run03, but r was found the correct parameter is OBS_MODE, not OBE_MODE. Eric-san pointed out that if you run the command via launcher, overwriting function sometimes may not work. |
| Comment by eric [ 19/Sep/21 ] |
|
> I tested the new commands during the engineering run03, but r was found the correct parameter is OBS_MODE, not OBE_MODE.
Just to prevent any confusion: the correct keyword is "OBS_MOD" not "OBS_MODE"
|