[INSTRM-424] Update drpActor to match current PFS DRP. Created: 23/Jul/18 Updated: 15/May/19 Due: 27/Jul/18 Resolved: 15/May/19 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | SM1 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 3 |
| Sprint: | SM1-2019 G |
| Description |
|
The `drpActor` was created a long long time ago. Make sure it matches the current system. |
| Comments |
| Comment by arnaud.lefur [ 13/Nov/18 ] |
|
Quick update : We still have an issue with the DetrendTask: command failed: AssertionError() at /opt/lsst/software/stack/stack/miniconda3-4.3.21-10a4fa6/Linux64/base/16.0/python/lsst/base/packages.py:156 However, it's working when we are using subprocess to call detrend.py; It's not very elegant but I guess that's fine for now.
|
| Comment by cloomis [ 09/Jan/19 ] |
|
I think we solved that with the work on Dec. 20, and the master Dockerfile.icsdrp contains the change. |
| Comment by hassan [ 18/Jan/19 ] |
|
arnaud.lefur, fmadec: can you check the docker image to confirm the fix? Then we can close this ticket. |
| Comment by hassan [ 05/Feb/19 ] |
|
fmadec will be checking this shortly (~10 Feb) |
| Comment by fmadec [ 11/Feb/19 ] |
|
We just tried the latest master pfs-pipe2d using the docker icsdrp and we still have the same issue:
root INFO: Running: lsst.pipe.base.cmdLineTask.DetrendTask.parseAndRun('/drp/r1', '-calib=/drp/r1/CALIB', 'rerun=ginga/detrend', 'doraise', 'clobber-versions', '-id', 'visit=11909')
2019-02-11 10:38:23.542Z cmds 20 CommandLink.py:121 > 1 2 f text="command failed: AssertionError() at /opt/lsst/software/stack/stack/miniconda3-4.3.21-10a4fa6/Linux64/base/16.0/python/lsst/base/packages.py:156"
|
| Comment by hassan [ 21/Feb/19 ] |
|
Craig needs to run it at IDG to determine what the problem is. As LAM have a workaround, this is not critical. |
| Comment by cloomis [ 13/May/19 ] |
|
Grr. We got past the python environment problems, but have run into a conflict between lsst.base.packages.getPythonPackages() and the (non-standard twisted.version.version_, which is an object and not a string, and which triggers an AssertionError. The fix requires a change to lsst.base — I'll try to negotiate something. In the meanwhile, we need to add the following to the end of lsst.base.packages.getVersionFromPythonModule: if not isinstance(version, str):
raise ValueError('version is not a string')
|
| Comment by arnaud.lefur [ 14/May/19 ] |
|
detrend now works fine with the new patch It has been merged to master and tagged as 0.0.9 |
| Comment by cloomis [ 15/May/19 ] |
|
pfs_piped merged at 8e0d1bd (Dockerfile.icsdrp changes) Looks like the ics_drpActor change made on the |