[INSTRM-327] Name MEB keyword fields Created: 19/Apr/18 Updated: 03/Jul/18 Resolved: 03/Jul/18 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_mebActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | chihyi |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | cloomis |
| Description |
|
Can the power and temps keyword fields be named? This would change, say:
Key('power', Int()*4,
help='MCS power status'),
to
Key('power',
Int(name='MCS_computer', units='V'),
Int(name='name_2', units='V'),
Int(name='name_3', units='V'),
Int(name='name_4', units='V'),
help='MCS power status'),
I don't know whether spaces are allowed, but I think we should avoid them: the names should be useable as variables, etc. |
| Comments |
| Comment by chihyi [ 19/Apr/18 ] |
|
Craig, what's units='V' means? For temps, it's in Celsius. So what's the units to use? |
| Comment by cloomis [ 19/Apr/18 ] |
|
It is not that important — I’d use “degC”. |
| Comment by chihyi [ 19/Apr/18 ] |
|
I have pushed the code to GitHub. Please check. |
| Comment by cloomis [ 19/Apr/18 ] |
|
Looks great, thanks. |
| Comment by rhl [ 19/Apr/18 ] |
|
I think Craig failed to mention that the motivation for this change is to simplify the connection of keys to alerts when things are out of specification (and which are at least sometimes sent to Subaru's STS system)
|
| Comment by cloomis [ 03/Jul/18 ] |
|
This was tested during the 2018-04 run |