[INSTRM-263] Remove compiled binary files in ics_msim_proto Created: 09/Dec/17 Updated: 31/Mar/23 Resolved: 31/Mar/23 |
|
| Status: | Won't Fix |
| Project: | Instrument control development |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | shimono | Assignee: | cloomis |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
chyan and I found many compiled binary files are included in ics_msim_proto repository. |
| Comments |
| Comment by shimono [ 09/Dec/17 ] |
|
chatted with chyan, we are easier to remove current repository than editing history, since we just have only one commit. if anyone have any objection, comment to this ticket in a few days (like by 12 Dec 2017). |
| Comment by rhl [ 09/Dec/17 ] |
|
I think you can just go ahead and do this without asking for permission via JIRA. If you want to modify a repo, the easiest way is git bfg |
| Comment by shimono [ 10/Dec/17 ] |
|
I encountered many times that entire my work had no mean after quite a while (incl. a year span) after I did some work or documentation, by comments or strong direction by management, so taking a time for formal review should be safer. Thank you for pointing bfg cleaner, but VS has a feature to remove all resultant binaries, so it should be safer to use such official tool, I suppose. |
| Comment by rhl [ 11/Dec/17 ] |
|
What does, "VS" mean? We're talking git here, recovering from a mistake. Once you've git rm the binaries (and added them to .gitignore) the problem won't reoccur, so the only problem is cleaning up the mess. I agree that deleting the entire repo and starting over is one way, and git bfg is the semi-standard other way; it's easier than using various git filtering commands. So I must be missing something. |
| Comment by shimono [ 12/Dec/17 ] |
|
VS is Visual Studio used for building codes/binaries in this repository. |
| Comment by rhl [ 14/Dec/17 ] |
|
Why are we using visual studio to build this code (I assume that we are building on a Linux box)? And what's the relationship between VS removing binaries and this problem? To be clear I'm perfectly happy with your with deleting and rebuilding this git repository – go ahead – but please explain what the build tools have to do with stopping this problem from reoccurring. |
| Comment by shimono [ 18/Dec/17 ] |
|
As we heard during a breakout session for PFI control of science WG gathering at MPA 2017, msim is MPS simulator which runs GUI window on Windows OS and simulates MPS to command from GUI and list of commands directly to Cobra FPGA. This ics_msim_proto is the repository for msim code, so this repository is built with VS to make binaries running on Windows OS. |
| Comment by yuki.moritani [ 31/Mar/23 ] |
|
I close this as it is obsolete. |