[INSTRM-241] Add blank README Created: 25/Oct/17  Updated: 07/Dec/17  Resolved: 07/Dec/17

Status: Won't Fix
Project: Instrument control development
Component/s: ics_ansible, ics_dnsmasq
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: shimono Assignee: shimono
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: cloomis

 Description   

At some init script, invoke of daemon will exit when /etc/dnsmasq.d/README is missing.
Add blank file...

> # /etc/dnsmasq.d/README is a non-conffile installed by the dnsmasq package.
> # Should the dnsmasq package be removed, the following test ensures that
> # the daemon is no longer started, even if the dnsmasq-base package is
> # still in place.
> test -e /etc/dnsmasq.d/README || exit 0

 Comments   
Comment by cloomis [ 25/Oct/17 ]

I'm not sure I understand: are you saying that (some) dnsmasq packages already use README in that way and so we always need to provide one? Or are you saying that you want to add that logic to avoid some later problem?

Comment by shimono [ 25/Oct/17 ]

Above lines are copied from /etc/init.d/dnsmasq file in my environment, which is a bit old.
so, it was fine in new production environment. but I think LAM is in the same version (arnaud.lefur no?)?

> $ apt show dnsmasq
> Package: dnsmasq
> Version: 2.72-3+deb8u2

Comment by arnaud.lefur [ 25/Oct/17 ] 
Package: dnsmasq
Version: 2.72-3+deb8u2

Yes, that's the same version.

Comment by shimono [ 18/Nov/17 ]

I think I should made some mistake.

  • README was originally installed by the package itself, and init script depends on that file
  • ansible role downloads git repository to /etc/dnsmasq.d, and to avoid fatal error, role deletes README before execution of git

So, it seems, I shall change ansible role rather than adding blank README to our dnsmasq repository.

Comment by shimono [ 21/Nov/17 ]
  • clearing the target directory of configuration (/etc/dnsmasq.d/) is required for git clone
  • backup/restore README file is not good on idempotency point of view
  • current active version does not depend on README file in init script, and no reason to install old version for new installation

therefore, I'd propose to

  • mark this as wontfix
  • just 'touch README' if required in existing installation, but not to have README in repository

For updating configuration files of dnsmasq, it would be easier just to run git pull (and reload service) but not to re-run ansible role.

Comment by shimono [ 29/Nov/17 ]

mark as in review for approval to move this into WONTFIX.

Comment by cloomis [ 07/Dec/17 ]

Since current versions do not depend on the README, I agree that we can ignore it.

Generated at Sat Feb 10 16:22:58 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.