[#INSTRM-2271] Make pfsConfig ARMS match actual physical configuration. Check vs. pfsDesign request

[INSTRM-2271] Make pfsConfig ARMS match actual physical configuration. Check vs. pfsDesign request Created: 09/May/24 Updated: 14/May/24 Resolved: 14/May/24
Status:	Done
Project:	Instrument control development
Component/s:	ics_iicActor
Affects Version/s:	None
Fix Version/s:	None

Type:

Task

Priority:

Normal

Reporter:

cloomis

Assignee:

arnaud.lefur

Resolution:

Done

Votes:

0

Labels:

EngRun

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Story Points:

1

Sprint:

EngRun16May

Description

All of the following visits (and several others) were configured with the med res. grating in, and had m-arm FITS files. But some of the pfsConfig files showed r in the ARMS card. For iic/sps, the issues are:

all the "engineering" visits/designs are wrong
some of the pfsDesigns (calspec and allfluxstd) had incorrect ARMS. Not iic's problem, but it should respond better.

We think the pfsConfig files should always match the physical configuration. If the grating position and the pfsDesign conflict, either the exposure should be rejected, or the grating moved to match the pfsDesign, or some forceGrating argument should be required.

  pfsConfig name               ARMS                  DSGN_NAM
-------------------------      ---- ------------------------------------------

0x70b4acc77695a624-110023.fits  brn                      cobraHome-MOD4_group2
0x70b4acc77695a624-110024.fits  brn                      cobraHome-MOD4_group2
0x06790bc0ce68e0d3-110264.fits  brn                                  cobraHome
0x662cf9deec5c1ce9-110266.fits   br                     phiCrossing-2022-06-19
0x662cf9deec5c1ce9-110267.fits   br                     phiCrossing-2022-06-19
[ ... ]
0x0045d686a297b83b-110439.fits  bmn                             PPC_M_96207814
0x2b06fae346c34863-110464.fits   br  calspec_3944_sm3_pa+00_run16_fluxstd_v3.3
0x2cf7af63a300c1e6-110489.fits  bmn                             PPC_M_20511660
0x35160c54f442dcb0-110504.fits   br allfluxstd_field2_pa+00_run16_fluxstd_v3.3
0x35160c54f442dcb0-110522.fits   br allfluxstd_field2_pa+00_run16_fluxstd_v3.3
0x35160c54f442dcb0-110523.fits   br allfluxstd_field2_pa+00_run16_fluxstd_v3.3
0x356b50cd140b34e5-110491.fits  bmn                             PPC_M_35334630
0x6d832ca291636984-110480.fits  bmn               ga1_pa+90_run16_fluxstd_v3.3
0x6d832ca291636984-110481.fits  bmn               ga1_pa+90_run16_fluxstd_v3.3
0x7a726bf04d6bedfa-110441.fits  bmn                             PPC_M_33407196
0x51773baa1a359f2e-110541.fits   br                   thetaCrossing-2022-06-19
0x51773baa1a359f2e-110543.fits   br                   thetaCrossing-2022-06-19

Comments

Comment by Masayuki Tanaka [ 09/May/24 ]

I have checked the visits in EDR2. I only looked at visits with pfsMerged, but it looks like a lot of files after the Nov 2022 run need to be corrected (n is missing).
#column
1 visit

2 pfsConfig.arms

3 arms in pfsMerged

4 ignore

-----------------------------------------------------------

82595 br br [1197, 1196, 1, 0]
82596 br br [1197, 1196, 1, 0]
82642 br br [1197, 1196, 1, 0]
82665 br br [1197, 1196, 1, 0]
82840 br br [1197, 1196, 1, 0]
82905 br br [1197, 1196, 1, 0]
82906 br br [1197, 1196, 1, 0]
82916 br br [1197, 1196, 1, 0]
82954 br br [1197, 1196, 1, 0]
82965 br br [1197, 1196, 1, 0]
82978 br br [1197, 1196, 1, 0]
83002 br br [1197, 1196, 1, 0]
83003 br br [1197, 1196, 1, 0]
83081 br br [1197, 1196, 1, 0]
83082 br br [1197, 1196, 1, 0]
83095 br br [1197, 1196, 1, 0]
83137 br br [1197, 1193, 1, 0]
83147 br br [1197, 1193, 4, 0]
83149 br br [1197, 1196, 1, 0]
83162 br br [1197, 1196, 1, 0]
83218 bm br [1197, 1196, 1, 0]
83219 bm bm [1197, 0, 1197, 0]
83232 bm bm [1197, 0, 1197, 0]
83244 br br [1197, 1196, 1, 0]
83245 br br [1197, 1196, 1, 0]
83246 br br [1197, 1196, 1, 0]
83247 br br [1197, 1196, 1, 0]
83248 br br [1197, 1196, 1, 0]
83249 br br [1197, 1196, 1, 0]
91563 br brn [1197, 1196, 1, 597]
91778 br brn [1197, 1196, 1, 597]
91782 br brn [1197, 1196, 1, 597]
91784 br brn [1197, 1196, 1, 597]
91881 br brn [1197, 1196, 1, 597]
91894 br brn [1197, 1196, 1, 597]
91895 br brn [1197, 1196, 1, 597]
91897 br brn [1197, 1196, 1, 597]
91898 br brn [1197, 1196, 1, 597]
91901 br brn [1197, 1196, 1, 597]
92014 br brn [1197, 1196, 1, 597]
92114 br brn [1197, 1196, 1, 597]
92116 br brn [1197, 1196, 1, 597]
92117 br brn [1197, 1196, 1, 597]
92135 br brn [1197, 1196, 1, 597]
92136 br brn [1197, 1196, 1, 597]
92137 br brn [1197, 1196, 1, 597]
92138 br brn [1197, 1196, 1, 597]
92536 bm bmn [1197, 0, 1197, 597]
92537 bm bmn [1197, 0, 1197, 597]
92557 br brn [1197, 1196, 1, 597]
92558 br brn [1197, 1196, 1, 597]
92560 br brn [1197, 1196, 1, 597]
92561 br brn [1197, 1196, 1, 597]
92562 br brn [1197, 1196, 1, 597]
92643 br brn [1197, 1196, 1, 597]
92644 br brn [1197, 1196, 1, 597]
92646 br brn [1197, 1196, 1, 597]
92733 bm bmn [1197, 0, 1197, 597]
92734 bm bmn [1197, 0, 1197, 597]
92736 br brn [1197, 1196, 1, 597]
92738 br brn [1197, 1196, 1, 597]
92740 br brn [1197, 1196, 1, 597]
92743 br brn [1197, 1196, 1, 597]
92892 bm bmn [1197, 0, 1197, 597]
92893 bm bmn [1197, 0, 1197, 597]
92897 br brn [1197, 1196, 1, 597]
92903 br brn [1197, 1196, 1, 597]
92904 br brn [1197, 1196, 1, 597]
92974 br brn [1197, 1196, 1, 597]
92975 br brn [1197, 1196, 1, 597]
93301 bm bmn [1197, 0, 1197, 597]
93302 bm bmn [1197, 0, 1197, 597]
93365 br brn [1197, 1196, 1, 597]
93366 br brn [1197, 1196, 1, 597]
93376 br brn [1197, 1196, 1, 597]
93377 br brn [1197, 1196, 1, 597]
97083 br brn [1197, 1197, 0, 1184]
97127 br brn [1197, 1197, 0, 1184]
97137 br brn [1197, 1197, 0, 1184]
97138 br brn [1197, 1197, 0, 1184]
97164 br brn [1197, 1197, 0, 1184]
97252 br brn [1197, 1197, 0, 1184]
97253 br brn [1197, 1197, 0, 1184]
97301 br brn [1197, 1197, 0, 1184]
97314 br brn [1197, 1197, 0, 1184]
97378 br brn [1197, 1197, 0, 1184]
97379 br brn [1197, 1197, 0, 1184]
97484 br brn [1191, 1197, 0, 1184]
97485 br brn [1193, 1197, 0, 1184]
97546 br brn [1197, 1197, 0, 1184]
97548 br brn [1197, 1197, 0, 1184]
97550 br brn [1197, 1197, 0, 1184]
97581 br brn [1197, 1197, 0, 1184]
97587 br brn [1197, 1197, 0, 1184]
97696 br brn [1197, 1197, 0, 1184]
97698 br brn [1197, 1197, 0, 1184]
97813 br brn [1197, 1197, 0, 1184]
97814 br brn [1197, 1197, 0, 1184]
97821 bm bmn [1197, 0, 1190, 1184]
97828 br brn [1197, 1197, 0, 1184]
97993 br brn [1197, 1197, 0, 1184]
98004 bm bmn [1197, 0, 1197, 1184]
98014 br brn [1197, 1197, 0, 1184]
98031 br brn [1197, 1197, 0, 1184]
98034 br brn [1197, 1197, 0, 1184]
98042 br brn [1197, 1197, 0, 1184]
98043 br brn [1197, 1197, 0, 1184]
98049 br brn [1197, 1197, 0, 1184]
98050 br brn [1197, 1197, 0, 1184]
98059 br brn [1197, 1197, 0, 1183]
98208 br brn [1197, 1197, 0, 1184]
98318 br brn [1197, 1197, 0, 1184]
98330 br brn [1197, 1197, 0, 1184]
98336 br brn [1197, 1197, 0, 1184]
98337 br brn [1197, 1197, 0, 1184]
98390 br brn [1197, 1197, 0, 1184]
98392 br brn [1197, 1197, 0, 1184]
98394 br brn [1197, 1197, 0, 1184]
98408 bm bmn [1197, 0, 1197, 1184]
98817 br brn [1197, 1197, 0, 1184]
99039 br brn [1197, 1197, 0, 1184]
99040 br brn [1197, 1197, 0, 1184]
99050 br brn [1197, 1197, 0, 1184]
99056 br brn [1197, 1197, 0, 1184]
99058 br brn [1197, 1197, 0, 1184]
99067 br brn [1197, 1197, 0, 1184]

Comment by arnaud.lefur [ 09/May/24 ]

For the calib(cobraHome, mod4_groupN, does it means the design should have all the arms brnm ? and then the pfsConfig set the current red resolution ?

Comment by arnaud.lefur [ 14/May/24 ]

merged as iicActor:2.5.15 .

iic will now reject exposure if the arm is not included in the declared pfsDesign
(unless forceGrating is used)

Generated at Wed Apr 09 22:01:58 JST 2025 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.