[INSTRM-2111] set pfsConfig.fiberStatus to UNILLUMINATED according to expected illumination Created: 11/Nov/23  Updated: 23/Nov/23  Resolved: 23/Nov/23

Status: Done
Project: Instrument control development
Component/s: ics_iicActor
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: arnaud.lefur Assignee: arnaud.lefur
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to INSTRM-2116 add pfs_config_fiber.fiber_status column Done
Story Points: 2
Sprint: EDR+AIT

 Description   

set fiberStatus correctly in pfsConfig according to the expected illumination, eg :

  • bias and dark set all fibers to UNILLUMINATED
  • engineering fibers set to UNILLUMINATED if IIS has not been used
  • science fibers set to UNILLUMINATED if DCB, PFILAMPS.. has not been used.


 Comments   
Comment by cloomis [ 11/Nov/23 ]

Hmm. Not sure about changing the properties of the fibers and thus the pfsConfigId for darks and biases. The configuration of the fibers is not changing.

Also, would you only change the status for science fibers when taking arcs/flats? Is UNILLUMINATED supposed to mean expected-to-be-dark, or something else?

Comment by arnaud.lefur [ 14/Nov/23 ]

I don't think the hash ever change if we update fiberStatus.
But your second point still hold, the configuration of the fibers effectively not changing.
I'm not sure it matters very much since fiberStatus is not used anywhere for biases and darks reductions, but I'll defer to rhl
I will change the status for science fibers and engineering fibers for arc, flat and even object because technically nothing forbid to illuminate the engineering fibers while exposing on the sky.

UNILLUMINATED = 5, "not illuminated; ignore any flux"

Yes, "expected-to-be-dark" is my current understanding.

Comment by arnaud.lefur [ 23/Nov/23 ]

merged as spsActor 1.6.7, can be deactivated through actorConfig
I've let biases and darks untouched for now.

Generated at Sat Feb 10 16:43:06 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.