[INSTRM-2092] Check mask of Broken Fibers in xml file Created: 29/Oct/23  Updated: 26/Nov/23  Resolved: 24/Nov/23

Status: Done
Project: Instrument control development
Component/s: pfs_instdata
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: yuki.moritani Assignee: chyan
Resolution: Done Votes: 0
Labels: near-term
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File INSTRM-2092.ipynb    
Issue Links:
Relates
relates to INSTRM-1847 Add broken fiber of Cable B3 to Cobra... Done

 Description   

Under INSTRM-1729 the schema of mask for the broken fiber changed to identify which part  of the fibers (i.e., Cable A, B, C) are broken.

The idea was add another bit to identify the broken part, so `COBRA_INVISIBLE_MASK` and one of `FIBER_{ABC}_BROKEN` are raised for broken fibers.

COBRA_OK_MASK = 0x0001 # a synthetic summary bit: 1 for good, 0 for bad.
 COBRA_INVISIBLE_MASK = 0x0002 # 1 if the fiber is not visible
 COBRA_BROKEN_THETA_MASK = 0x0004 # 1 if the phi motor do not work
 COBRA_BROKEN_PHI_MASK = 0x0008 # 1 if the theta motor does not work
 FIBER_A_BROKEN: 0x0010 # 5th bit is 1 if cable A is broken
 FIBER_B_BROKEN: 0x0020 # 6th bit is 1 if cable B is broken
 FIBER_C_BROKEN: 0x0040 # 7th bit is 1 if cable C is broken

However, the latest xmlfile (ALL_final_20221113_mm.xml) show 0x0002 for the fibers broken at cable C, and 0x0010 for those broken at cable A.

 Comments   
Comment by chyan [ 24/Nov/23 ]

This issue is fixed with new XML file.

Comment by yuki.moritani [ 26/Nov/23 ]

Have you upload the new XML file to pfs_instdata? I couldn't find here.. (I'm sorry if I missed something..)

https://github.com/Subaru-PFS/pfs_instdata/tree/master/data/pfi/modules/ALL

 

Generated at Sat Feb 10 16:42:55 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.