[INSTRM-206] eups role shall check git updated or not Created: 23/Sep/17 Updated: 22/Feb/18 Resolved: 22/Feb/18 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_ansible |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | shimono | Assignee: | shimono |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2017-10A |
| Description |
|
before configure and make, eups role shall check git checkout is updated or not, and be better not to run configure/make etc. when cloned one is not updated. |
| Comments |
| Comment by shimono [ 21/Nov/17 ] |
|
git module output changed=true for local updated. TASK [dnsmasq : Checkout ics_dnsmasq repository] *******************************
task path: /data1/shimono/git/github-pfs/ics_ansible/roles/dnsmasq/tasks/main.yml:16
changed: [lf01] => {"after": "943ea3df75a422330272e65933a1eb08b3a8f89e", "before": "e620607fa369b74fe3ac3e5ec60d341e5fe01749", "changed": true, "warnings": []}
|
| Comment by cloomis [ 07/Dec/17 ] |
|
Slightly puzzled here. A specific tagged version of eups is being installed (vars/main.yml: eups.version). So why would we care about the git repo getting changed? If we were running off a branch or master, sure. |
| Comment by shimono [ 07/Dec/17 ] |
|
I've added this flag not to run configure/make, as in description of ticket. |
| Comment by cloomis [ 07/Dec/17 ] |
|
I'd like to state that I do not think that this kind of ticket needs a proper review. This is just a straightforward technical fix, and you should feel free to simply make it and close the ticket. |
| Comment by shimono [ 18/Dec/17 ] |
|
I am not sure where is the line for straightforward fix or not, one line fix could be a straightforward fix sometimes but not for sometimes. For this one, I can agree this is just a technical bug, but still it should be important to be reviewed not to introduce any regression... |
| Comment by shimono [ 22/Feb/18 ] |
|
merged. |