[#INSTRM-2057] Solving the confusion between final and nominal position in pfs_config

[INSTRM-2057] Solving the confusion between final and nominal position in pfs_config_fiber table Created: 16/Aug/23 Updated: 30/Aug/23 Resolved: 30/Aug/23
Status:	Done
Project:	Instrument control development
Component/s:	None
Affects Version/s:	None
Fix Version/s:	None

Type:

Task

Priority:

Normal

Reporter:

chyan

Assignee:

arnaud.lefur

Resolution:

Done

Votes:

Labels:

EngRun

Remaining Estimate:

Not Specified

Time Spent:

Not Specified

Original Estimate:

Not Specified

Attachments:

Figure 1-26.png

Figure 1-27.png

Sprint:

Eng13Oct

Description

Please see attached figure. The nominal position seems to consistent with the target position from FPS log. However, the final position doesn't consistent with the position found from cobra_match table.

Comments

Comment by arnaud.lefur [ 30/Aug/23 ]

Could you provide which cobras are problematic ? I've checked for both visits(97010, 99068) pfs_config_fiber and cobra_match tables but I don't see any inconsistencies.
Eg this don't raise any exception :

# checking first that fiberIds do match.
np.testing.assert_almost_equal(pfs_config_fiber.fiber_id.to_numpy(), cobra_match.fiber_id.to_numpy())

np.testing.assert_almost_equal(pfs_config_fiber.pfi_center_final_x_mm.to_numpy(), cobra_match.pfi_center_x_mm.to_numpy(), decimal=6)
np.testing.assert_almost_equal(pfs_config_fiber.pfi_center_final_y_mm.to_numpy(), cobra_match.pfi_center_y_mm.to_numpy(), decimal=6)

Comment by chyan [ 30/Aug/23 ]

Ah, I found what is going on. It is a small bug from my side.

Generated at Sat Feb 10 16:42:33 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.

[INSTRM-2057] Solving the confusion between final and nominal position in pfs_config_fiber table Created: 16/Aug/23 Updated: 30/Aug/23 Resolved: 30/Aug/23