[INSTRM-2030] Disallow all invalid motor moves Created: 20/Jul/23 Updated: 20/Jul/23 |
|
| Status: | Open |
| Project: | Instrument control development |
| Component/s: | ics_xcuActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The xcus were just sent motors moveFocus microns=-50 abs, which commands to a position far beyond the home switch. They accepted this and drove into the home switch (which is OK, but not great because it overshoots and requires re-homing). Other move commands better validate their arguments, but the new moveFocus does not. Maybe move the check lower into a routine common to all moves. |